RESOLVED FIXED 43008
Simplify speech input plumbing in webcore and webkit 
https://bugs.webkit.org/show_bug.cgi?id=43008
Summary Simplify speech input plumbing in webcore and webkit
Satish Sampath
Reported 2010-07-26 15:01:15 PDT
A few related changes to make things simpler with the speech input plumbing between WebCore <> WebKit. This will help in subsequent patches for adding testing/mocking code and the mac/linux port implementation. - Each WebCore::InputFieldSpeechButtonElement object was creating one WebCore::SpeechInput object for accessing the WebKit speech client, and there were 2 listener interfaces involved. Instead, now WebCore::Page creates only 1 instance of WebCore::SpeechInput and WebCore::InputFieldSpeechButtonElement calls the webkit APIs through this object. - WebKit::SpeechInputClientImpl was having some intelligence to deal with starting speech recognition when another instance was already running. This has now been moved to the above mentioned WebCore::SpeechInput object which WebCore::Page maintains. With this change, WebKit::SpeechInputClientImpl becomes a dumb proxy between WebCore and the WebKit. - Added necessary methods to WebCore::SpeechInput and WebCore::SpeechInputClient so that the above mentioned functionality can be moved from WebKit::SpeechInputClientImpl to WebCore::SpeechInput.
Attachments
Patch (23.23 KB, patch)
2010-07-26 15:19 PDT, Satish Sampath 		no flags
DetailsFormatted DiffDiff
Patch (23.04 KB, patch)
2010-07-26 22:55 PDT, Satish Sampath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Satish Sampath
Comment 1 2010-07-26 15:19:21 PDT
Created attachment 62618 [details] Patch
Kent Tamura
Comment 2 2010-07-26 22:25:35 PDT
Comment on attachment 62618 [details] Patch The code change looks OK. But please re-make the patch with the latest WebKit. Our commit-queue has a bug for ChangeLog diff not starting with the first line like your patch. > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index e26d1854a9a330a50728633b8e55d07feb945f6d..7226ef6e566e8a6849f4f2cc3ccd614f118f3963 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,5 +1,39 @@ > 2010-07-26 Satish Sampath <satish@chromium.org> > > + Reviewed by NOBODY (OOPS!). > + > + Simplify speech input plumbing in webcore and webkit > + https://bugs.webkit.org/show_bug.cgi?id=43008 > diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog > index 0309952965ca68664268ba361e5c63f80f6c7612..3dddb2d6bc562091b15d992050558259a1c7d6dd 100644 > --- a/WebKit/chromium/ChangeLog > +++ b/WebKit/chromium/ChangeLog > @@ -1,5 +1,20 @@ > 2010-07-26 Satish Sampath <satish@chromium.org> > > + Reviewed by NOBODY (OOPS!). > + > + Simplify speech input plumbing in webcore and webkit > + https://bugs.webkit.org/show_bug.cgi?id=43008
Satish Sampath
Comment 3 2010-07-26 22:55:59 PDT
Created attachment 62646 [details] Patch Merged with latest.
Kent Tamura
Comment 4 2010-07-26 23:43:38 PDT
Comment on attachment 62646 [details] Patch OK
WebKit Commit Bot
Comment 5 2010-07-27 00:51:09 PDT
Comment on attachment 62646 [details] Patch Clearing flags on attachment: 62646 Committed r64111: <http://trac.webkit.org/changeset/64111>
WebKit Commit Bot
Comment 6 2010-07-27 00:51:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.