RESOLVED FIXED 42879
Inline HTMLElementStack::top 
https://bugs.webkit.org/show_bug.cgi?id=42879
Summary Inline HTMLElementStack::top
Adam Barth
Reported 2010-07-23 00:58:01 PDT
Inline HTMLElementStack::top
Attachments
Patch (2.04 KB, patch)
2010-07-23 01:00 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.96 KB, patch)
2010-07-23 10:08 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-23 01:00:51 PDT
Created attachment 62389 [details] Patch
Adam Barth
Comment 2 2010-07-23 01:01:19 PDT
== pre == Running 20 times Ignoring warm-up run (4734) 4185 4244 4196 4192 4210 4200 4240 4217 4254 4240 4260 4263 4259 4280 4265 4253 4321 4268 4288 4289 avg 4246.2 stdev 35.68697241291281 == post == Running 20 times Ignoring warm-up run (4740) 4217 4172 4206 4189 4222 4199 4202 4214 4200 4222 4219 4230 4264 4230 4261 4260 4255 4300 4268 4317 avg 4232.35 stdev 36.32117151194328
Eric Seidel (no email)
Comment 3 2010-07-23 05:04:40 PDT
Comment on attachment 62389 [details] Patch OK, again a comment would be nice. I guess the comments could grow old rather quickly, but I hate how the rest of WebKit has so many needlessly inline functions. You can never tell which were inline because the person was lazy, and which because they tested a benchmark and found it to be a speedup.
Adam Barth
Comment 4 2010-07-23 10:08:39 PDT
Created attachment 62439 [details] Patch for landing
WebKit Commit Bot
Comment 5 2010-07-23 11:54:15 PDT
Comment on attachment 62439 [details] Patch for landing Clearing flags on attachment: 62439 Committed r63990: <http://trac.webkit.org/changeset/63990>
WebKit Commit Bot
Comment 6 2010-07-23 11:54:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.