RESOLVED FIXED 42668
Fix fast/dom/title-content-write-set.html for HTML5 tree builder 
https://bugs.webkit.org/show_bug.cgi?id=42668
Summary Fix fast/dom/title-content-write-set.html for HTML5 tree builder
Adam Barth
Reported 2010-07-20 14:25:42 PDT
Fix fast/dom/title-content-write-set.html for HTML5 tree builder
Attachments
Patch (3.07 KB, patch)
2010-07-20 14:36 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.68 KB, patch)
2010-07-20 15:11 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.37 KB, patch)
2010-07-20 15:18 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-20 14:36:12 PDT
Created attachment 62113 [details] Patch
Darin Adler
Comment 2 2010-07-20 14:50:49 PDT
Comment on attachment 62113 [details] Patch > -PassRefPtr<StringImpl> CharacterData::parserAppendData(const String& arg) > +PassRefPtr<StringImpl> CharacterData::appendDataCommon(const String& arg) > +void CharacterData::parserAppendData(const String& arg) > + PassRefPtr<StringImpl> appendDataCommon(const String& arg); Please omit the name "arg" here. It doesn't add anything.
Darin Adler
Comment 3 2010-07-20 14:51:18 PDT
Comment on attachment 62113 [details] Patch > -PassRefPtr<StringImpl> CharacterData::parserAppendData(const String& arg) > +PassRefPtr<StringImpl> CharacterData::appendDataCommon(const String& arg) > +void CharacterData::parserAppendData(const String& arg) I meant to say. Are you willing to use a word, such as "data" here, instead of an abbreviation, "arg"?
Eric Seidel (no email)
Comment 4 2010-07-20 14:51:36 PDT
Comment on attachment 62113 [details] Patch It seems the main cause of this bug is that dispatchModifiedEvent has a bad name. It really should say something about calling childrenChanged, or be split into two functions or something.
Adam Barth
Comment 5 2010-07-20 15:00:13 PDT
> I meant to say. Are you willing to use a word, such as "data" here, instead of an abbreviation, "arg"? Yeah, data is a better name. I brought the name forward from the code originally with out thinking about it.
Adam Barth
Comment 6 2010-07-20 15:11:20 PDT
Created attachment 62121 [details] Patch for landing
WebKit Commit Bot
Comment 7 2010-07-20 15:12:34 PDT
Comment on attachment 62113 [details] Patch Clearing flags on attachment: 62113 Committed r63779: <http://trac.webkit.org/changeset/63779>
WebKit Commit Bot
Comment 8 2010-07-20 15:12:38 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 9 2010-07-20 15:13:42 PDT
Darn, the commit bot picked up the patch before I removed cq+. I'll land a followup patch.
Adam Barth
Comment 10 2010-07-20 15:18:01 PDT
Created attachment 62122 [details] Patch for landing
Adam Barth
Comment 11 2010-07-20 15:18:42 PDT
Reopening so the commit bot can land the updated patch.
WebKit Commit Bot
Comment 12 2010-07-20 16:03:08 PDT
Comment on attachment 62122 [details] Patch for landing Clearing flags on attachment: 62122 Committed r63782: <http://trac.webkit.org/changeset/63782>
WebKit Commit Bot
Comment 13 2010-07-20 16:03:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.