RESOLVED FIXED 42604
Update expected results for a "tricky" test 
https://bugs.webkit.org/show_bug.cgi?id=42604
Summary Update expected results for a "tricky" test
Adam Barth
Reported 2010-07-19 16:21:26 PDT
Update expected results for a "tricky" test
Attachments
Patch (4.34 KB, patch)
2010-07-19 16:24 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-19 16:24:16 PDT
Created attachment 62010 [details] Patch
Eric Seidel (no email)
Comment 2 2010-07-19 16:57:28 PDT
Comment on attachment 62010 [details] Patch OK.
WebKit Commit Bot
Comment 3 2010-07-20 01:02:49 PDT
Comment on attachment 62010 [details] Patch Rejecting patch 62010 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Parsed 4 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/html5lib/resources/tricky01.dat patching file LayoutTests/html5lib/runner-expected-html5.txt Hunk #1 FAILED at 286. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected-html5.txt.rej patching file LayoutTests/html5lib/runner-expected.txt Full output: http://queues.webkit.org/results/3569261
Eric Seidel (no email)
Comment 4 2010-07-20 15:54:03 PDT
Here are reduced test cases: #data <b>1<i>2<p>3</b>4 #errors #document | <html> | <head> | <body> | <b> | "1" | <i> | "2" | <i> | <p> | <b> | "3" | "4" #data <b id="b">1<i id="i">2<p>3<script>document.getElementById("b").id = "c";document.getElementById("i").id = "j"</script></b>4 #errors #document | <html> | <head> | <body> | <b> | id="c" | "1" | <i> | id="j" | "2" | <i> | id="i" | <p> | <b> | id="b" | "3" | <script> | "document.getElementById("b").id = "c";document.getElementById("i").id = "j"" | "4" It seems you can't hit AAA 6.5 without also hitting step 8, so both callsites ended up as one test.
Eric Seidel (no email)
Comment 5 2010-07-20 15:55:13 PDT
Sorry, wrong bug.
Adam Barth
Comment 6 2010-07-20 19:14:03 PDT
Comment on attachment 62010 [details] Patch This should land cleanly behind the patch in Bug 42594.
WebKit Commit Bot
Comment 7 2010-07-20 19:41:57 PDT
Comment on attachment 62010 [details] Patch Clearing flags on attachment: 62010 Committed r63799: <http://trac.webkit.org/changeset/63799>
WebKit Commit Bot
Comment 8 2010-07-20 19:42:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.