WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
42235
HTMLTreeBuilder foster parents when it should not
https://bugs.webkit.org/show_bug.cgi?id=42235
Summary
HTMLTreeBuilder foster parents when it should not
Eric Seidel (no email)
Reported
2010-07-13 23:16:09 PDT
HTMLTreeBuilder foster parents when it should not
Attachments
Patch
(12.61 KB, patch)
2010-07-13 23:19 PDT
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2010-07-13 23:19:44 PDT
Created
attachment 61473
[details]
Patch
Adam Barth
Comment 2
2010-07-13 23:45:19 PDT
Comment on
attachment 61473
[details]
Patch Nice.
WebKit Commit Bot
Comment 3
2010-07-14 06:07:30 PDT
Comment on
attachment 61473
[details]
Patch Rejecting patch 61473 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Last 500 characters of output: ore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/html/HTMLConstructionSite.cpp Hunk #3 FAILED at 209. Hunk #4 succeeded at 271 (offset 1 line). Hunk #5 succeeded at 366 (offset -40 lines). 1 out of 5 hunks FAILED -- saving rejects to file WebCore/html/HTMLConstructionSite.cpp.rej patching file WebCore/html/HTMLConstructionSite.h Hunk #1 succeeded at 65 with fuzz 2 (offset -2 lines). patching file WebCore/html/HTMLTreeBuilder.cpp Hunk #1 succeeded at 1698 (offset 4 lines). Full output:
http://webkit-commit-queue.appspot.com/results/3523174
Eric Seidel (no email)
Comment 4
2010-07-14 11:52:43 PDT
Comment on
attachment 61473
[details]
Patch This should apply now.
WebKit Commit Bot
Comment 5
2010-07-14 18:06:24 PDT
Comment on
attachment 61473
[details]
Patch Clearing flags on attachment: 61473 Committed
r63386
: <
http://trac.webkit.org/changeset/63386
>
WebKit Commit Bot
Comment 6
2010-07-14 18:06:28 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7
2010-07-14 19:20:48 PDT
http://trac.webkit.org/changeset/63386
might have broken Chromium Mac Release The following changes are on the blame list:
http://trac.webkit.org/changeset/63384
http://trac.webkit.org/changeset/63385
http://trac.webkit.org/changeset/63386
http://trac.webkit.org/changeset/63389
http://trac.webkit.org/changeset/63383
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug