RESOLVED FIXED 42143
Fix line number handling in HTMLTreeBuilder to fix a zillion layout tests 
https://bugs.webkit.org/show_bug.cgi?id=42143
Summary Fix line number handling in HTMLTreeBuilder to fix a zillion layout tests
Eric Seidel (no email)
Reported 2010-07-12 22:37:31 PDT
Fix line number handling in HTMLTreeBuilder to fix a zillion layout tests
Attachments
Patch (1.78 KB, patch)
2010-07-12 22:40 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-07-12 22:40:03 PDT
Created attachment 61328 [details] Patch
Adam Barth
Comment 2 2010-07-12 22:51:42 PDT
Comment on attachment 61328 [details] Patch This whole +1 thing is out of control. Can we use the type system to make this easier? Can we just agree on either 0 or 1 based?
Eric Seidel (no email)
Comment 3 2010-07-12 22:59:08 PDT
Interesting thought. We could use the type system to convert from parser line numbers to script line numbers. I completely agree that the +1 thing is out of control.
WebKit Commit Bot
Comment 4 2010-07-12 23:53:28 PDT
Comment on attachment 61328 [details] Patch Clearing flags on attachment: 61328 Committed r63180: <http://trac.webkit.org/changeset/63180>
WebKit Commit Bot
Comment 5 2010-07-12 23:53:33 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-07-13 00:40:05 PDT
http://trac.webkit.org/changeset/63180 might have broken Chromium Win Release The following changes are on the blame list: http://trac.webkit.org/changeset/63178 http://trac.webkit.org/changeset/63179 http://trac.webkit.org/changeset/63180 http://trac.webkit.org/changeset/63181
Note You need to log in before you can comment on or make changes to this bug.