RESOLVED FIXED 41932
[Chromium] Update ThemeChromiumMac.mm for the recent changes of ThemeMac.mm 
https://bugs.webkit.org/show_bug.cgi?id=41932
Summary [Chromium] Update ThemeChromiumMac.mm for the recent changes of ThemeMac.mm
Kent Tamura
Reported 2010-07-08 23:01:18 PDT
[Chromium] Update ThemeChromiumMac.mm for the recent changes of ThemeMac.mm
Attachments
Patch (10.47 KB, patch)
2010-07-09 01:58 PDT, Kent Tamura 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-07-09 01:58:58 PDT
Created attachment 61017 [details] Patch
Eric Seidel (no email)
Comment 2 2010-07-15 21:22:10 PDT
Comment on attachment 61017 [details] Patch I don't think there is much I can review here. Only really rubber-stamp. Assuming it works for Chromium, rs=me.
Joseph Pecoraro
Comment 3 2010-07-15 21:32:16 PDT
Comment on attachment 61017 [details] Patch > +++ b/WebCore/platform/chromium/ThemeChromiumMac.mm > + case OuterSpinButtonPart: { > + static const int stepperMargin[4] = { 0, 0, 0, 0}; Probably a negligible style issue. Missing a space at the end? "0 };"
Kent Tamura
Comment 4 2010-07-15 21:55:28 PDT
Committed r63514: <http://trac.webkit.org/changeset/63514>
Kent Tamura
Comment 5 2010-07-15 22:19:04 PDT
(In reply to comment #3) > (From update of attachment 61017 [details]) > > +++ b/WebCore/platform/chromium/ThemeChromiumMac.mm > > + case OuterSpinButtonPart: { > > + static const int stepperMargin[4] = { 0, 0, 0, 0}; > > Probably a negligible style issue. Missing a space at the end? "0 };" Thank you for pointing it out. I have fixed it and the same one in ThemeMac.mm by http://trac.webkit.org/changeset/63518
Note You need to log in before you can comment on or make changes to this bug.