RESOLVED FIXED 41439
BogusCommentState should come in from the cold 
https://bugs.webkit.org/show_bug.cgi?id=41439
Summary BogusCommentState should come in from the cold
Adam Barth
Reported 2010-06-30 17:30:01 PDT
BogusCommentState should come in from the cold
Attachments
Patch (4.99 KB, patch)
2010-06-30 17:33 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-06-30 17:33:14 PDT
Created attachment 60174 [details] Patch
Eric Seidel (no email)
Comment 2 2010-06-30 17:49:45 PDT
Comment on attachment 60174 [details] Patch LayoutTests/html5lib/webkit-resumer-expected.txt:159 + resources/webkit01.dat: Geez, we still need to fix this output. WebCore/html/HTMLTokenizer.cpp:1078 + else if (cc == InputStreamPreprocessor::endOfFileMarker) I should have written these as isEndOfFileMarker(cc) Why do we need ContinueBogusCommentState? Why not just check m_token->type() == Comment?
Adam Barth
Comment 3 2010-06-30 19:18:53 PDT
> WebCore/html/HTMLTokenizer.cpp:1078 > + else if (cc == InputStreamPreprocessor::endOfFileMarker) > I should have written these as isEndOfFileMarker(cc) Oh, ok. I just copied another state/ > Why do we need ContinueBogusCommentState? Why not just check m_token->type() == Comment? Because that would be an extra branch per character.
Eric Seidel (no email)
Comment 4 2010-06-30 22:09:28 PDT
(In reply to comment #3) > > Why do we need ContinueBogusCommentState? Why not just check m_token->type() == Comment? > > Because that would be an extra branch per character. Really? I meant in the BogusCommentState itself. Are we commonly in the BogusCommentState? I agree this is fewer branches.
WebKit Commit Bot
Comment 5 2010-07-01 00:40:10 PDT
Comment on attachment 60174 [details] Patch Clearing flags on attachment: 60174 Committed r62233: <http://trac.webkit.org/changeset/62233>
WebKit Commit Bot
Comment 6 2010-07-01 00:40:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.