RESOLVED FIXED 41433
make_names.pl should ignore pre-processor definitions when generating FooNames.* 
https://bugs.webkit.org/show_bug.cgi?id=41433
Summary make_names.pl should ignore pre-processor definitions when generating FooNames.*
Eric Seidel (no email)
Reported 2010-06-30 16:09:21 PDT
make_names.pl should ignore pre-processor definitions when generating FooNames.*
Attachments
work in progress (6.75 KB, patch)
2010-06-30 16:11 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-06-30 16:11:11 PDT
Created attachment 60162 [details] work in progress
Adam Barth
Comment 2 2010-06-30 16:12:11 PDT
You should generate names for the extra tags we need in the new tree builder too.
Eric Seidel (no email)
Comment 3 2010-06-30 16:14:47 PDT
This will require changes to make_names to make it ignore preprocessor definitions in the Names case, and not in the ElementFactory case. I'm not quite sure how to do that yet though. This is important for making a correctly functioning HTML5 TreeBuilder since it needs to respect "foreignObject" as a name, even if our foreignObject support is disabled. I'm not actively working on this bug atm, but we'll have to fix it before we can pass the entire libhtml5 test suite in all configurations.
Adam Barth
Comment 4 2010-06-30 16:29:22 PDT
Block against master?
Note You need to log in before you can comment on or make changes to this bug.