RESOLVED FIXED 41116
Reset ENABLE_IMAGE_RESIZER to 0 
https://bugs.webkit.org/show_bug.cgi?id=41116
Summary Reset ENABLE_IMAGE_RESIZER to 0
Sterling Swigart
Reported 2010-06-23 17:55:09 PDT
Created attachment 59588 [details] ENABLE_IMAGE_RESIZER=0 Someone mistakenly set this value to 1 in features.gypi, but the feature is still under development.
Attachments
ENABLE_IMAGE_RESIZER=0 (474 bytes, patch)
2010-06-23 17:55 PDT, Sterling Swigart 		levin: review-
DetailsFormatted DiffDiff
ENABLE_IMAGE_RESIZER=0 (1.09 KB, patch)
2010-06-24 10:21 PDT, Sterling Swigart 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2010-06-24 00:54:00 PDT
Comment on attachment 59588 [details] ENABLE_IMAGE_RESIZER=0 Sorry this needs a changelog. r- for that. Typically Chromium has defines set to 1 even when the feature is under development (at least at a certain point), but at this stage I agree that it would be good for this feature to not be compiled into chromium.
Kent Tamura
Comment 2 2010-06-24 02:32:56 PDT
I enabled it in http://trac.webkit.org/changeset/61547 because - it's good to check build by buidbot. - We'd like to minimize features.gypi change as possible. A change for features.gypi needs manual operation on Chromium buildbots for webkit.org. It's ok to reset it to 0 if it's hard to develop the feature with ENABLE_IMAGE_RESIZER=1.
Dimitri Glazkov (Google)
Comment 3 2010-06-24 07:22:02 PDT
(In reply to comment #2) > I enabled it in http://trac.webkit.org/changeset/61547 because > - it's good to check build by buidbot. > - We'd like to minimize features.gypi change as possible. > A change for features.gypi needs manual operation on Chromium buildbots for webkit.org. > > It's ok to reset it to 0 if it's hard to develop the feature with ENABLE_IMAGE_RESIZER=1. manual operation == dglazkov going to the hallway and mucking with computers made in previous century.
Sterling Swigart
Comment 4 2010-06-24 10:21:59 PDT
Created attachment 59669 [details] ENABLE_IMAGE_RESIZER=0
Dimitri Glazkov (Google)
Comment 5 2010-06-24 10:27:26 PDT
If we're going to enable it soon, can we spare my knees from doing this?
WebKit Commit Bot
Comment 6 2010-06-25 20:22:36 PDT
Comment on attachment 59669 [details] ENABLE_IMAGE_RESIZER=0 Clearing flags on attachment: 59669 Committed r61936: <http://trac.webkit.org/changeset/61936>
WebKit Commit Bot
Comment 7 2010-06-25 20:22:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.