Created attachment 59046 [details] Patch

Attachment 59046 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/html/CSSPreloadScanner.cpp:93: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] WebCore/html/CSSPreloadScanner.cpp:116: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] WebCore/html/CSSPreloadScanner.cpp:135: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 59046 [details] Patch Can we share the code with the legacy parser? That would make this diff easier to verify correctness because we'd see the moved code. (Ideally we'd split CSSPreloadScanner out of the old parser first before doing this patch.)

I was just going to delete the old preload scanner.

Attachment 59046 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3270341

Comment on attachment 59046 [details] Patch We came up with a testing strategy in person using: 1. a slow script which document.write('<plaintext>') 2. A docuemnt with: <script src="slow_script_which_document_write_plaintext.js"></script> <style> @import "foo.css" </style> and look for a loader callback for foo.css

Created attachment 59057 [details] Patch

Comment on attachment 59057 [details] Patch Thank you for adding testing.

Committed r61366: <http://trac.webkit.org/changeset/61366>

http://trac.webkit.org/changeset/61366 might have broken Qt Linux Release

Qt and GTK don't support dumpResourceResponseMIMETypes, so we can't run these tests.

Nice, thanks!