Created attachment 58534 [details] Patch

Some questions from IRC review: 1) Is there a need to rename the existing parser classes before they are ready to be phased out? 2) Should XMLTokenizer* be renamed too? 3) Likewise the various Tokenizer helper classes in the loader/ directory for handling tree building for non-HTML non-XML types (TextTokenizer, PluginTokenizer, MediaTokenizer, ImageTokenizer, maybe more I am missing).

Comment on attachment 58534 [details] Patch Rejecting patch 58534 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Last 500 characters of output: t.h patching file WebCore/loader/TextDocument.cpp Hunk #1 FAILED at 183. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/loader/TextDocument.cpp.rej patching file WebCore/loader/TextDocument.h patching file WebCore/svg/SVGDocumentExtensions.cpp patching file WebCore/wml/WMLDocument.cpp patching file WebCore/wml/WMLErrorHandling.cpp Hunk #1 FAILED at 38. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/wml/WMLErrorHandling.cpp.rej patching file WebCore/wml/WMLTemplateElement.cpp Full output: http://webkit-commit-queue.appspot.com/results/3257227

Comment on attachment 58534 [details] Patch Rejecting patch 58534 from commit-queue. Unexpected failure when processing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 58534, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: date_status return NetworkTransaction().run(lambda: self._post_status_to_server(queue_name, status, patch, results_file)) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/net/networktransaction.py", line 56, in run self._check_for_timeout() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/net/networktransaction.py", line 63, in _check_for_timeout raise NetworkTimeout() webkitpy.common.net.networktransaction.NetworkTimeout

Created attachment 58605 [details] Patch for landing

Comment on attachment 58605 [details] Patch for landing Clearing flags on attachment: 58605 Committed r61104: <http://trac.webkit.org/changeset/61104>

All reviewed patches have been landed. Closing bug.