RESOLVED FIXED 39275
Make it possible to enable the new HTML5Tokenizer for testing 
https://bugs.webkit.org/show_bug.cgi?id=39275
Summary Make it possible to enable the new HTML5Tokenizer for testing
Eric Seidel (no email)
Reported 2010-05-18 02:08:31 PDT
Make it possible to enable the new HTML5Tokenizer for testing
Attachments
Patch (28.31 KB, patch)
2010-05-18 02:14 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (28.33 KB, patch)
2010-05-18 02:37 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (28.95 KB, patch)
2010-05-18 02:56 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (28.95 KB, patch)
2010-05-18 03:09 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-05-18 02:14:02 PDT
Created attachment 56339 [details] Patch
Adam Barth
Comment 2 2010-05-18 02:21:49 PDT
Comment on attachment 56339 [details] Patch WebCore/html/HTML5Tokenizer.cpp:59 + if (m_lexer->nextToken(m_source, token)) { nextToken is void. There's an EOF token that means we're done. WebCore/page/Settings.h:312 + bool usesHTML5Parser() const { return m_usesHTML5Parser; } use instead of uses?
Adam Barth
Comment 3 2010-05-18 02:22:27 PDT
Comment on attachment 56339 [details] Patch The comments above plus mjs's name recommendation on the setting.
Eric Seidel (no email)
Comment 4 2010-05-18 02:37:42 PDT
Created attachment 56342 [details] Patch for landing
Eric Seidel (no email)
Comment 5 2010-05-18 02:56:32 PDT
Created attachment 56343 [details] Patch for landing
Eric Seidel (no email)
Comment 6 2010-05-18 03:09:37 PDT
Created attachment 56346 [details] Patch for landing
Eric Seidel (no email)
Comment 7 2010-05-18 03:17:34 PDT
Committed r59664: <http://trac.webkit.org/changeset/59664>
WebKit Review Bot
Comment 8 2010-05-18 03:23:22 PDT
http://trac.webkit.org/changeset/59664 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release
Eric Seidel (no email)
Comment 9 2010-05-18 03:36:44 PDT
Hmm... build-webkit succeeded locally, I swear. Anyway, fixing.
Eric Seidel (no email)
Comment 10 2010-05-18 03:39:47 PDT
Committed r59665: <http://trac.webkit.org/changeset/59665>
Eric Seidel (no email)
Comment 11 2010-05-18 04:04:47 PDT
Committed r59667: <http://trac.webkit.org/changeset/59667>
Note You need to log in before you can comment on or make changes to this bug.