RESOLVED WONTFIX 37426
new-run-webkit-tests should use the ServerProcess abstraction in chromium.py 
https://bugs.webkit.org/show_bug.cgi?id=37426
Summary new-run-webkit-tests should use the ServerProcess abstraction in chromium.py
Dirk Pranke
Reported 2010-04-11 18:45:27 PDT
The code to launch and read from test_shell in chromium.py predates the ServerProcess abstraction that WebKit Mac uses. It should be rewritten to use it to minimize code duplication.
Attachments
Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-11-11 20:00:54 PST
Tony, I'm punting this over to you, because it becomes true when we remove the test_shell code and only use DRT.
Tony Chang
Comment 2 2010-11-12 10:05:14 PST
Ok, after we switch, I'll see about removing the test_shell related code.
Tony Chang
Comment 3 2011-02-04 16:34:59 PST
Hmm, as mentioned in bug 34826 comment 20, it is non-trivial to make use of ServerProcess on Windows python. I'm not sure if this is something we want to pursue.
Dirk Pranke
Comment 4 2011-03-18 18:46:53 PDT
punting back to me ;)
Dirk Pranke
Comment 5 2011-04-06 19:44:43 PDT
I don't think it should block bug 34984 and I plan to clear the blocking flag on Mon 4/11. If you disagree, now would be a good time to speak up :).
Dirk Pranke
Comment 6 2011-04-12 18:05:31 PDT
clearing blocking flag.
Dirk Pranke
Comment 7 2011-04-15 17:11:49 PDT
See bug 37426 for a way to make serverprocess work w/o blocking on win32.
Dirk Pranke
Comment 8 2011-05-31 18:54:00 PDT
A more accurate description of this would probably be that we should just use the WebKitDriver implementation if we ever want to switch the Chromium DRT to webkit-style output. Whether or not the WebKitDriver implementation works on windows is a separate issue that should probably be tracked under a separate bug. I'm marking this as WONTFIX for now and clearing ownership; if anyone disagrees, feel free to reopen it.
Note You need to log in before you can comment on or make changes to this bug.