WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
36233
Revert WebGL context attributes changes 33416 /
r56074
and 36200 /
r56093
https://bugs.webkit.org/show_bug.cgi?id=36233
Summary
Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
Kenneth Russell
Reported
2010-03-17 11:37:35 PDT
After discussion, rather than try to work around the OpenGL driver bugs exposed by the fix for
https://bugs.webkit.org/show_bug.cgi?id=33416
on the fly, we are going to revert it and re-apply it later via the commit queue. A large refactoring of some of the affected code is imminent and it will be much easier to track the history if the changes are made after that refactoring rather than before. At the same time we are also going to re-enable the failing WebGL tests on the bots which were skipped in
https://bugs.webkit.org/show_bug.cgi?id=36200
.
Attachments
Patch
(54.25 KB, patch)
2010-03-17 12:52 PDT
,
Kenneth Russell
fishd
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kenneth Russell
Comment 1
2010-03-17 12:52:46 PDT
Created
attachment 50939
[details]
Patch Patch reverting 33416, build fix 36189, and skipping of affected tests from 36200
Darin Fisher (:fishd, Google)
Comment 2
2010-03-17 13:39:19 PDT
Comment on
attachment 50939
[details]
Patch There's no need to seek review when reverting code.
Kenneth Russell
Comment 3
2010-03-17 14:11:59 PDT
Committed
r56127
: <
http://trac.webkit.org/changeset/56127
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug