RESOLVED FIXED 36124
[Qt] Multiselect Popup - SelectElement refactoring. 
https://bugs.webkit.org/show_bug.cgi?id=36124
Summary [Qt] Multiselect Popup - SelectElement refactoring.
Luiz Agostini
Reported 2010-03-15 10:05:01 PDT
As it is today it is not possible to the menulists popups to tell SelectElement that more then one option is selected. If you select one the other ones selected state will turn off. For <select multiple> I needed to extend the API used by menulist popups. This is the first step.
Attachments
patch (9.08 KB, patch)
2010-03-15 10:17 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch 2 (8.73 KB, patch)
2010-03-15 10:42 PDT, Luiz Agostini 		koivisto: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
(committed in r56116) patch 3 (8.75 KB, patch)
2010-03-16 10:50 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2010-03-15 10:17:50 PDT
Created attachment 50717 [details] patch
Luiz Agostini
Comment 2 2010-03-15 10:42:17 PDT
Created attachment 50718 [details] patch 2
Antti Koivisto
Comment 3 2010-03-15 10:50:31 PDT
Comment on attachment 50718 [details] patch 2 r=me
WebKit Commit Bot
Comment 4 2010-03-15 13:39:10 PDT
Comment on attachment 50718 [details] patch 2 Rejecting patch 50718 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Antti Koivisto', '--force']" exit_code: 1 Last 500 characters of output: + WebCore/dom/SelectElement.cpp | 93 +++++++++++++++++++++------------------- WebCore/dom/SelectElement.h | 3 + 3 files changed, 72 insertions(+), 44 deletions(-) ------------------------------------------------------------------- patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/dom/SelectElement.cpp patching file WebCore/dom/SelectElement.h Hunk #1 FAILED at 97. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/dom/SelectElement.h.rej Full output: http://webkit-commit-queue.appspot.com/results/885008
Eric Seidel (no email)
Comment 5 2010-03-15 18:57:53 PDT
We will need an updated patch to land this via the commit queue.
Antonio Gomes
Comment 6 2010-03-16 09:21:01 PDT
*** Bug 34842 has been marked as a duplicate of this bug. ***
Luiz Agostini
Comment 7 2010-03-16 10:50:42 PDT
Created attachment 50808 [details] (committed in r56116) patch 3 Adjusting previous patch.
Luiz Agostini
Comment 8 2010-03-17 06:11:17 PDT
(In reply to comment #5) > We will need an updated patch to land this via the commit queue. Why is it taking so long for the bots to check this patch and for landing?
Antonio Gomes
Comment 9 2010-03-17 10:25:51 PDT
Comment on attachment 50808 [details] (committed in r56116) patch 3 since the CQ is stuck, I committed it manually on behalf of Luiz. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/SelectElement.cpp M WebCore/dom/SelectElement.h Committed r56116
Eric Seidel (no email)
Comment 10 2010-03-19 11:10:51 PDT
The commit-queue gets stuck when people break the build. You can see the status of the queue here: http://webkit-commit-queue.appspot.com/
Note You need to log in before you can comment on or make changes to this bug.