RESOLVED FIXED 35586
Make IntPoint usable as a hash key 
https://bugs.webkit.org/show_bug.cgi?id=35586
Summary Make IntPoint usable as a hash key
Antti Koivisto
Reported 2010-03-02 10:06:51 PST
What the title says.
Attachments
patch (2.14 KB, patch)
2010-03-02 10:10 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
move to IntPointHash.h to avoid including hash headers all over the place (7.90 KB, patch)
2010-03-03 03:40 PST, Antti Koivisto 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2010-03-02 10:10:40 PST
Created attachment 49812 [details] patch
WebKit Review Bot
Comment 2 2010-03-02 10:19:31 PST
Attachment 49812 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/IntPoint.h:220: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2010-03-02 10:25:57 PST
Comment on attachment 49812 [details] patch In the case of WebCore::String we chose to put the hashing into a separate header rather than adding HashFunctions.h and HashTraits.h into every files that includes PlatformString.h. Perhaps we should do the same thing here?
Antti Koivisto
Comment 4 2010-03-02 13:39:00 PST
(In reply to comment #3) > (From update of attachment 49812 [details]) > In the case of WebCore::String we chose to put the hashing into a separate > header rather than adding HashFunctions.h and HashTraits.h into every files > that includes PlatformString.h. Perhaps we should do the same thing here? Yeah, good idea. This is included all over.
Antti Koivisto
Comment 5 2010-03-03 03:40:28 PST
Created attachment 49896 [details] move to IntPointHash.h to avoid including hash headers all over the place
Oliver Hunt
Comment 6 2010-03-03 03:44:27 PST
Comment on attachment 49896 [details] move to IntPointHash.h to avoid including hash headers all over the place r=me, assuming you remove the superfluous project file changes
Antti Koivisto
Comment 7 2010-03-03 04:53:02 PST
Sending WebCore/ChangeLog Sending WebCore/WebCore.pro Sending WebCore/WebCore.xcodeproj/project.pbxproj Adding WebCore/platform/graphics/IntPointHash.h Transmitting file data .... Committed revision 55455.
Note You need to log in before you can comment on or make changes to this bug.