RESOLVED DUPLICATE of bug 48322 35143
check-webkit-style ignores JavaScriptCore/qt/api directory 
https://bugs.webkit.org/show_bug.cgi?id=35143
Summary check-webkit-style ignores JavaScriptCore/qt/api directory
Jędrzej Nowacki
Reported 2010-02-19 03:46:36 PST
check-webkit-style ignores *.cpp and *.h files inside the JavaScriptCore/qt/ subdirectory which I believe is wrong. Message posted by WebKit Review Bot: Ignoring "JavaScriptCore/qt/api/qscriptstring.cpp": this file is exempt from the style guide. An use case can be found in bug 34843.
Attachments
Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2010-11-02 13:47:22 PDT
Is this a bug? In WebKitTools/Scripts/webkitpy/style/checker.py, _SKIPPED_FILES_WITH_WARNING it sounds like this is because these are part of the qt api and it doesn't follow WebKit style. If just a few rules should be omitted, this can be done in the section: _PATH_RULES_SPECIFIER
David Levin
Comment 2 2010-11-02 13:53:53 PDT
I'll resolve this of a dup of a later bug since it has a patch attached. *** This bug has been marked as a duplicate of bug 48322 ***
Note You need to log in before you can comment on or make changes to this bug.