RESOLVED FIXED 34741
MathML Support for mfrac 
https://bugs.webkit.org/show_bug.cgi?id=34741
Summary MathML Support for mfrac
Alex Milowski
Reported 2010-02-08 21:06:36 PST
Created attachment 48393 [details] The patch to add support for mfrac. This patch adds support for non-beveled fractions for the MathML mfrac element. There is basic support for the fraction line thickness.
Attachments
The patch to add support for mfrac. (74.45 KB, patch)
2010-02-08 21:06 PST, Alex Milowski 		no flags
DetailsFormatted DiffDiff
Updated the patch to the latest trunk and added other changes suggested (76.89 KB, patch)
2010-03-03 14:49 PST, Alex Milowski 		kenneth: review-
DetailsFormatted DiffDiff
Updated mfrac implementation with custom painting of fraction line (109.14 KB, patch)
2010-03-22 08:23 PDT, Alex Milowski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Milowski
Comment 1 2010-03-03 14:49:43 PST
Created attachment 49951 [details] Updated the patch to the latest trunk and added other changes suggested I also added some changes suggested by Sausset François.
Kenneth Rohde Christiansen
Comment 2 2010-03-13 10:28:47 PST
Comment on attachment 49951 [details] Updated the patch to the latest trunk and added other changes suggested > + if (lastChild()) > + if (lastChild()->isRenderBlock()) { > + RenderBlock* denominator = toRenderBlock(lastChild()); > + int previousWidth = denominator->style()->borderTopWidth(); > + int borderWidth = static_cast<int>(ceil(gFractionBarWidth * style()->fontSize())); > + denominator->style()->setBorderTopWidth(previousWidth * borderWidth); > + } > + > + if (previousSibling()) > + if (previousSibling()->isRenderBlock()) { > + RenderBlock* sibling = toRenderBlock(previousSibling()); > + verticalAlignCompute(sibling); > + RenderBlock::layout(); > + return; > + } > + if (nextSibling()) > + if (nextSibling()->isRenderBlock()) { > + RenderBlock* sibling = toRenderBlock(nextSibling()); > + verticalAlignCompute(sibling); > + } > + The above is against our coding style. An if with contents (comments included) spanding more than one line should use {}
Alex Milowski
Comment 3 2010-03-22 08:23:56 PDT
Created attachment 51291 [details] Updated mfrac implementation with custom painting of fraction line
Kenneth Rohde Christiansen
Comment 4 2010-03-22 09:58:33 PDT
Comment on attachment 51291 [details] Updated mfrac implementation with custom painting of fraction line Looks good!
WebKit Commit Bot
Comment 5 2010-03-22 10:20:52 PDT
Comment on attachment 51291 [details] Updated mfrac implementation with custom painting of fraction line Clearing flags on attachment: 51291 Committed r56340: <http://trac.webkit.org/changeset/56340>
WebKit Commit Bot
Comment 6 2010-03-22 10:20:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.