NEW 33734
check-webkit-style: Suppress the usual tab check for files having the allow-tabs property 
https://bugs.webkit.org/show_bug.cgi?id=33734
Summary check-webkit-style: Suppress the usual tab check for files having the allow-t...
Chris Jerdonek
Reported 2010-01-15 13:45:49 PST
This report is an outgrowth of the following report on excluding selected code/files/directories from certain style checks: https://bugs.webkit.org/show_bug.cgi?id=33684 More information on the allow-tabs property is in this e-mail: https://lists.webkit.org/pipermail/webkit-dev/2010-January/011331.html Question: It seems that git might not be able to "see" the allow-tabs property. See, for instance, the "Bugs" section of the man page for git-svn(1): > We ignore all SVN properties except svn:executable. Any unhandled properties are logged to $GIT_DIR/svn/<refname>/unhandled.log (from http://www.kernel.org/pub/software/scm/git/docs/git-svn.html ) Would implementing this enhancement mean that check-webkit-style will not yield correct results unless run from an SVN repository?
Attachments
Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-01-16 10:56:02 PST
Adding Kent to the CC since he added the tab check.
David Kilzer (:ddkilzer)
Comment 2 2010-01-16 11:56:39 PST
(In reply to comment #0) > Would implementing this enhancement mean that check-webkit-style will not yield > correct results unless run from an SVN repository? You could always fall back to a server-side check when using a git repository, although it will be slower: $ svn pl http://svn.webkit.org/repository/webkit/trunk/WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl Properties on 'http://svn.webkit.org/repository/webkit/trunk/WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl': allow-tabs
Note You need to log in before you can comment on or make changes to this bug.