WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
33433
Flaky Test: svg/dom/SVGScriptElement/script-set-href.svg
https://bugs.webkit.org/show_bug.cgi?id=33433
Summary
Flaky Test: svg/dom/SVGScriptElement/script-set-href.svg
Eric Seidel (no email)
Reported
2010-01-09 15:16:44 PST
svg/dom/SVGScriptElement/script-set-href.svg failed on Tiger Build Bot
http://build.webkit.org/results/Tiger%20Intel%20Release/r53038%20(7591)/results.html
--- layout-test-results/svg/dom/SVGScriptElement/script-set-href-expected.txt 2010-01-09 00:29:08.000000000 -0800 +++ layout-test-results/svg/dom/SVGScriptElement/script-set-href-actual.txt 2010-01-09 00:29:08.000000000 -0800 @@ -18,4 +18,4 @@ Set after insertion: PASS -Set twice before and once after insertion: PASS +Set twice before and once after insertion: FAIL This is the first time I've noticed this failure. No clue why.
http://trac.webkit.org/browser/trunk/LayoutTests/svg/dom/SVGScriptElement/script-set-href.svg
Written by mitz it seems, reviewed by Mark Rowe.
Attachments
Patch
(3.91 KB, patch)
2010-01-13 15:40 PST
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2010-01-09 15:18:12 PST
e3.setAttribute("onload", "if (window.layoutTestController) setTimeout('layoutTestController.notifyDone()', 100)"); I suspect this test is timing dependent and just flakey in general.
Eric Seidel (no email)
Comment 2
2010-01-13 15:08:01 PST
Just filed on the Gtk bot too:
http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r53205%20(2366)/svg/dom/SVGScriptElement/script-set-href-diffs.txt
Eric Seidel (no email)
Comment 3
2010-01-13 15:08:07 PST
***
Bug 31107
has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
Comment 4
2010-01-13 15:17:58 PST
Chromium's tracking tools have occasionally seen this fail as well:
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=svg%2Fdom%2FSVGScriptElement%2Fscript-set-href.svg&showExpectations=true&showLargeExpectations=true
Eric Seidel (no email)
Comment 5
2010-01-13 15:40:17 PST
Created
attachment 46514
[details]
Patch
WebKit Commit Bot
Comment 6
2010-01-13 16:41:30 PST
Comment on
attachment 46514
[details]
Patch Rejecting patch 46514 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11920 test cases. svg/dom/SVGScriptElement/script-set-href.svg -> failed Exiting early after 1 failures. 9735 tests run. 204.73s total testing time 9734 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output Full output:
http://webkit-commit-queue.appspot.com/results/184832
Eric Seidel (no email)
Comment 7
2010-01-13 16:46:38 PST
Passed for me locally, so I must have done something wrong. Investigating.
Eric Seidel (no email)
Comment 8
2010-01-13 16:58:09 PST
Looking at the results off the (16 core) bot, looks like my fears came true: /tmp/layout-test-results/svg/dom/SVGScriptElement/script-set-href-actual.txt - Self-closing <script> tag: PASS + Self-closing <script> tag: FAIL - Set before insertion: PASS + Set before insertion: FAIL - Set after insertion: PASS + Set after insertion: FAIL Looks like the earlier tests hadn't completed by the time the later ones did. The best way to fix this would be to sign up for the onload events of all of the script tags and only end the test once all of them have fired.
Eric Seidel (no email)
Comment 9
2010-01-14 13:30:02 PST
I am not actively working on this bug.
Eric Seidel (no email)
Comment 10
2010-03-22 17:45:08 PDT
Failed again for the commit-queue just now. Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12524 test cases. svg/dom/SVGScriptElement/script-set-href.svg -> failed Exiting early after 1 failures. 10243 tests run. 246.58s total testing time
Eric Seidel (no email)
Comment 11
2010-03-25 21:34:43 PDT
Failed again on the Leopard Debug bot:
http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r56594%20(11967)/svg/dom/SVGScriptElement/script-set-href-diffs.txt
I've seen it fail for the commit-queue locally as well.
Eric Seidel (no email)
Comment 12
2010-03-26 10:49:21 PDT
Another leopard failure:
http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r56631%20(12178)/svg/dom/SVGScriptElement/script-set-href-diffs.txt
Nikolas Zimmermann
Comment 13
2010-07-09 07:19:25 PDT
Changed component to SVG, so it shows up in my all-svg-bugs search.
Eric Seidel (no email)
Comment 14
2011-05-13 13:48:58 PDT
***
Bug 56790
has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
Comment 15
2011-05-13 13:49:05 PDT
***
Bug 37560
has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
Comment 16
2011-05-13 13:49:11 PDT
***
Bug 60118
has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
Comment 17
2011-05-13 13:50:10 PDT
I suspect this patch could be turned into a final fix with little effort, but I'm not actively working on this (just noticed when cleaning out some old git branches).
Ahmad Saleem
Comment 18
2024-01-27 11:27:40 PST
We still have [ Failure Pass ] expectation added in 2014 for Mac platforms:
https://searchfox.org/wubkat/rev/b96b33ee6c4c6dde7bf51c3744d6ccbc19a517e8/LayoutTests/platform/mac/TestExpectations#477
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug