RESOLVED FIXED 33095
SVG FilterEffects need to invalidate ResourceFilter on svgAttributeChanged 
https://bugs.webkit.org/show_bug.cgi?id=33095
Summary SVG FilterEffects need to invalidate ResourceFilter on svgAttributeChanged
Dirk Schulze
Reported 2010-01-01 07:54:59 PST
SVG FilterEffects need to invalidate ResourceFilter on svgAttributeChanged.
Attachments
Preperation of svgAttrChanged pactch (19.94 KB, patch)
2010-01-01 14:45 PST, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2010-01-01 14:45:00 PST
Created attachment 45735 [details] Preperation of svgAttrChanged pactch Preperation of svgAttrChanged pactch. Save reference to the ResourceFilter to invalidate if one effect changes Attribute. Next patch will add svgAttributeChanged and dynamic-update tests. It is also possible to create more than one Resource per Id. This helps to fix bug 19388.
WebKit Review Bot
Comment 2 2010-01-01 14:57:27 PST
style-queue ran check-webkit-style on attachment 45735 [details] without any errors.
Dirk Schulze
Comment 3 2010-01-02 05:16:38 PST
Comment on attachment 45735 [details] Preperation of svgAttrChanged pactch Got ASSERTION FAILED: object (SVGFilterElement.cpp:190 virtual WebCore::SVGResource* WebCore::SVGFilterElement::canvasResource(const WebCore::RenderObject*)) in Debug build.
Dirk Schulze
Comment 4 2010-01-02 06:38:57 PST
(In reply to comment #3) > (From update of attachment 45735 [details]) > Got ASSERTION FAILED: object > (SVGFilterElement.cpp:190 virtual WebCore::SVGResource* > WebCore::SVGFilterElement::canvasResource(const WebCore::RenderObject*)) > > in Debug build. This problem does only appear during LayoutTests. It also looks like a general bug in RenderSVGTextToTree. See bug 33105
Dirk Schulze
Comment 5 2010-01-02 16:59:28 PST
After talking with Niko on IRC it turns out, that SVGStyledElement is doing the job already. All effects and the filter itself inherit from SVGStyledElement. Closing this bug now.
Note You need to log in before you can comment on or make changes to this bug.