WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
32901
valueAsDate setter Part 1: millisecond -> ISODateTime conversion
https://bugs.webkit.org/show_bug.cgi?id=32901
Summary
valueAsDate setter Part 1: millisecond -> ISODateTime conversion
Kent Tamura
Reported
Wednesday, December 23, 2009 4:08:29 PM UTC
In order to implement HTMLInputElement::setValueAsDate, we need to implement 1. millisecond double value to ISODateTime conversion 2. ISODateTime to String conversion This bug handles the step 1 above.
Attachments
Proposed patch
(15.63 KB, patch)
2009-12-23 08:30 PST
,
Kent Tamura
mjs
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kent Tamura
Comment 1
Wednesday, December 23, 2009 4:30:25 PM UTC
Created
attachment 45441
[details]
Proposed patch
WebKit Review Bot
Comment 2
Wednesday, December 23, 2009 4:35:32 PM UTC
style-queue ran check-webkit-style on
attachment 45441
[details]
without any errors.
Maciej Stachowiak
Comment 3
Monday, December 28, 2009 10:12:27 AM UTC
This patch lacks tests. Perhaps it is only testable in combination with part 2, in which case I'd rather see the two combined into one patch with tests included.
Maciej Stachowiak
Comment 4
Monday, December 28, 2009 10:13:32 AM UTC
Comment on
attachment 45441
[details]
Proposed patch r- per comment above
Kent Tamura
Comment 5
Tuesday, December 29, 2009 4:52:50 PM UTC
Ok, I'm making testable patches. I have made a new bug,
Bug#33021
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug