NEW 32042
style-queue (or something) should r- patches missing ChangeLogs 
https://bugs.webkit.org/show_bug.cgi?id=32042
Summary style-queue (or something) should r- patches missing ChangeLogs
Eric Seidel (no email)
Reported 2009-12-01 17:16:46 PST
style-queue (or something) should r- patches missing ChangeLogs Or at least make a nasty comment in the bug. Rarely can one actually review a patch w/o a ChangeLog. We have at least one other bug about our tools warning us sooner, but if style-queue is the earliest we can get a warning, then so be it. It's better than the current pre-commit hook or reviewers spending time on it. The bot should point people to http://webkit.org/coding/contributing.html or possibly http://webkit.org/coding/contributing.html#changelogs
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2009-12-02 10:48:48 PST
A helpful comment would be OK, but you'd need to nominate the tool for reviewer status to actually r-. And there are cases when it makes more sense to just manually adapt and land a one time contributor's patch than to educate them about our process. Sometimes people do useful things without long-term involvement with the project.
Alexey Proskuryakov
Comment 2 2013-03-25 13:46:23 PDT
*** Bug 61458 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 3 2013-03-25 13:46:42 PDT
*** Bug 62021 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.