WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
31077
[Qt] ASSERT failure when receiving 401 HTTP Authentication response.
https://bugs.webkit.org/show_bug.cgi?id=31077
Summary
[Qt] ASSERT failure when receiving 401 HTTP Authentication response.
Yael
Reported
2009-11-03 12:12:29 PST
QNetworkReplyHandler::sendResponseIfNeeded() does not send the response for any error situation, but QNetworkReplyHandler::finish() calls client->didFinishLoading() for some error conditions. That leads to ASSERT(!m_response.isNull()) , in MainResourceLoader::didReceiveData(). If we decide to handle the error response as if there was no error, we should also send the response to the client in sendResponseIfNeeded().
Attachments
Patch
(1.24 KB, patch)
2009-11-03 14:16 PST
,
Yael
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yael
Comment 1
2009-11-03 14:16:16 PST
Created
attachment 42417
[details]
Patch This patch is only handling the ASSERT. HTTP auth support would be a separate bug.
WebKit Commit Bot
Comment 2
2009-11-04 09:09:01 PST
Comment on
attachment 42417
[details]
Patch Clearing flags on attachment: 42417 Committed
r50514
: <
http://trac.webkit.org/changeset/50514
>
WebKit Commit Bot
Comment 3
2009-11-04 09:09:07 PST
All reviewed patches have been landed. Closing bug.
Kenneth Rohde Christiansen
Comment 4
2009-11-09 06:42:26 PST
Did this patch fix any layout tests? Or should we add one?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug