RESOLVED FIXED299129
[text shaping] Selection paint rect should follow shaped content 
https://bugs.webkit.org/show_bug.cgi?id=299129
Summary [text shaping] Selection paint rect should follow shaped content
alan
Reported 2025-09-18 15:06:24 PDT
ssia
Attachments
Patch (15.73 KB, patch)
2025-09-18 15:39 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (15.77 KB, patch)
2025-09-19 08:19 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2025-09-18 15:39:27 PDT
Created attachment 476796 [details] Patch
Antti Koivisto
Comment 2 2025-09-19 06:14:12 PDT
Comment on attachment 476796 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=476796&action=review > Source/WebCore/rendering/TextBoxPainter.cpp:570 > + if (!isInsideShapedContent()) { > + fontCascade().adjustSelectionRectForText(m_renderer.canUseSimplifiedTextMeasuring().value_or(false), m_paintTextRun, selectionRect, startOffset, endOffset); > + return selectionRect; > + } maybe make the shaped content the branch or even factor it into a separate function?
alan
Comment 3 2025-09-19 08:19:50 PDT
Created attachment 476802 [details] [fast-cq]Patch
EWS
Comment 4 2025-09-19 10:23:50 PDT
Committed 300241@main (742a9580b8b7): <https://commits.webkit.org/300241@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 476802 [details].
Radar WebKit Bug Importer
Comment 5 2025-09-19 10:24:12 PDT
<rdar://problem/160949905>
Radar WebKit Bug Importer
Comment 6 2025-09-19 10:24:13 PDT
<rdar://problem/160949939>
Note You need to log in before you can comment on or make changes to this bug.