WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
284871
[CMake] Remove support for using an externally built copy of Skia
https://bugs.webkit.org/show_bug.cgi?id=284871
Summary
[CMake] Remove support for using an externally built copy of Skia
Adrian Perez
Reported
2024-12-18 01:22:13 PST
We currently support setting SKIA_ROOT_DIR in the environment pointing to a copy of the library built outside of the WebKit tree. This was useful during the initial bringup, but this has not been used for a good while. As per the FIXME in `Source/ThirdParty/skia/CMakeLists.txt`, we should remove this and support only in-tree Skia builds going forward. The `ext-skia-configure` script may be removed as well.
Attachments
Add attachment
proposed patch, testcase, etc.
Adrian Perez
Comment 1
2025-01-29 01:37:00 PST
Pull request:
https://github.com/WebKit/WebKit/pull/39682
EWS
Comment 2
2025-01-29 02:15:19 PST
Committed
289495@main
(ba4919dd2c05): <
https://commits.webkit.org/289495@main
> Reviewed commits have been landed. Closing PR #39682 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug