RESOLVED FIXED 284545
[scroll-animations] WPT test scroll-animations/scroll-timelines/scroll-animation-effect-phases.tentative.html has failures 
https://bugs.webkit.org/show_bug.cgi?id=284545
Summary [scroll-animations] WPT test scroll-animations/scroll-timelines/scroll-animat...
Antoine Quint
Reported 2024-12-12 06:52:04 PST
The WPT test scroll-animations/scroll-timelines/scroll-animation-effect-phases.html has one failure: FAIL Playback rate affects whether active phase boundary is inclusive. assert_not_equals: Animation effect is in active phase when current time is 100%. got disallowed value null
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-12-12 06:52:13 PST
<rdar://problem/141356963>
Antoine Quint
Comment 2 2025-02-17 06:29:41 PST
We fail the "Playback rate affects whether active phase boundary is inclusive" subtest in `scroll-animations/scroll-timelines/scroll-animation-effect-phases.tentative.html`. There are two issues here. The first issue is a faulty assertion function where `assert_phase` does not deal with `currentTime = 100%` being in the "active" phase for animations associated with a progress-based timeline. After fixing this we hit a debug ASSERT in WebKit though. Under `setBindingsTimeline()` at the very end of this test, when we change to the document timeline, we end up in a bad state where after calling `setCurrentTime()` the hold time is 0s but the start time is 100%. After that we set the hold time to the unresolved value since the start time is resolved. Then we're in a state where all the timing values are time-based except for the start time which remains progress-based. The test attempts to resolve this by setting `animation.currentTime = 0` right after, but we hit the debug assertion before being able to set that value.
Antoine Quint
Comment 3 2025-02-17 06:29:51 PST
*** Bug 287793 has been marked as a duplicate of this bug. ***
Antoine Quint
Comment 4 2025-02-21 04:35:01 PST
Pull request: https://github.com/WebKit/WebKit/pull/41055
Antoine Quint
Comment 5 2025-02-21 04:35:29 PST
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/50858
EWS
Comment 6 2025-02-21 07:04:03 PST
Committed 290787@main (03eccf44ee0d): <https://commits.webkit.org/290787@main> Reviewed commits have been landed. Closing PR #41055 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.