RESOLVED FIXED 28450
commit-queue/bugzilla-tool should build both Debug and Release 
https://bugs.webkit.org/show_bug.cgi?id=28450
Summary commit-queue/bugzilla-tool should build both Debug and Release
Eric Seidel (no email)
Reported 2009-08-19 00:39:43 PDT
commit-queue/bugzilla-tool should build both Debug and Release We're currently building whatever is the current "set-webkit-configuration" value. Which on the commit-queue machine is "release". We should probably change --commit-queue mode to build both, and possibly even run the LayoutTests in Debug mode instead of release mode (Debug will catch ASSERTs). Ideally this would all be handled by try-bots, but we'll use what we have for now. :) Tonight the commit-queue landed a patch which build and passed in release, but crashed 10 tests run in Debug mode (due to an ASSERT). This bug is about preventing such problems.
Attachments
Patch (8.41 KB, patch)
2010-01-03 18:57 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-12-19 23:27:27 PST
This will be much easier to do once we make the layout tests much faster using the fancy new fully-sharded run_webkit_tests.py.
Adam Barth
Comment 2 2010-01-03 18:57:04 PST
Created attachment 45762 [details] Patch
WebKit Review Bot
Comment 3 2010-01-03 19:02:02 PST
style-queue ran check-webkit-style on attachment 45762 [details] without any errors.
Eric Seidel (no email)
Comment 4 2010-01-03 19:03:59 PST
Comment on attachment 45762 [details] Patch LGTM.
WebKit Commit Bot
Comment 5 2010-01-03 19:12:42 PST
Comment on attachment 45762 [details] Patch Clearing flags on attachment: 45762 Committed r52701: <http://trac.webkit.org/changeset/52701>
WebKit Commit Bot
Comment 6 2010-01-03 19:12:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.