RESOLVED FIXED 278460
[GLib] Improve FPS counter 
https://bugs.webkit.org/show_bug.cgi?id=278460
Summary [GLib] Improve FPS counter
Pawel Lampe
Reported 2024-08-21 05:16:07 PDT
Currently - in skia builds - the FPS counter (that used to be shown when WEBKIT_SHOW_FPS=1) is not displayed
Attachments
Add attachment proposed patch, testcase, etc.
Pawel Lampe
Comment 1 2024-08-22 02:21:15 PDT
Pull request: https://github.com/WebKit/WebKit/pull/32580
Pawel Lampe
Comment 2 2025-04-11 06:11:23 PDT
As drawing FPS counter interferes with the graphics pipeline it should be avoided - it would be ideal to log FPS instead.
EWS
Comment 3 2025-04-26 00:50:09 PDT
Committed 294148@main (b7df35a60c2f): <https://commits.webkit.org/294148@main> Reviewed commits have been landed. Closing PR #32580 and removing active labels.
Diego Pino
Comment 4 2025-04-29 01:06:47 PDT
This changeset broke the build for WPE in ARM-32 bit architectures. https://build.webkit.org/#/builders/860/builds/19500 The reason is the changeset made use of the data type `std::atomic<std::optional<double>>`. The size of an optional is the size of the data type it stores plus the size of bool, which in this case is 9-bytes. In 32-bit architectures, atomic data types larger than 8-bytes require linking with libatomic. There was a test in the CMake files to determining whether to link with libatomic or not, but this use case was not managed.
Diego Pino
Comment 5 2025-04-29 01:08:01 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/44664
Diego Pino
Comment 6 2025-04-29 04:47:17 PDT
Pull request: https://github.com/WebKit/WebKit/pull/44682
EWS
Comment 7 2025-04-29 05:11:47 PDT
Committed 294245@main (20c693e72e84): <https://commits.webkit.org/294245@main> Reviewed commits have been landed. Closing PR #44682 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.