RESOLVED FIXED264297
REGRESSION (270226@main): Profiling symbols missing from JavaScriptCore.framework
https://bugs.webkit.org/show_bug.cgi?id=264297
Summary REGRESSION (270226@main): Profiling symbols missing from JavaScriptCore.frame...
David Kilzer (:ddkilzer)
Reported 2023-11-06 15:37:51 PST
Profiling symbols missing from JavaScriptCore.framework. This happened after introducing `libJavaScriptCore.a` in 270226@main since these two lines were moved from `JavaScriptCore.xcconfig` to `libJavaScriptCore.xcconfig` instead of to `BaseTarget.xcconfig`, which caused `-fprofile-instr-generate` not to be included when linking `JavaScriptCore.framework`: ``` CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING = $(CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING_$(ENABLE_LLVM_PROFILE_GENERATION)); CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING_ENABLE_LLVM_PROFILE_GENERATION = YES; ```
Attachments
Radar WebKit Bug Importer
Comment 1 2023-11-06 15:38:13 PST
David Kilzer (:ddkilzer)
Comment 2 2023-11-06 15:43:26 PST
EWS
Comment 3 2023-11-06 20:00:58 PST
Committed 270306@main (60d419eb1b25): <https://commits.webkit.org/270306@main> Reviewed commits have been landed. Closing PR #20070 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.