WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
261022
[TextureMapper] Move filter specific code from BitmapTextureGL to TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=261022
Summary
[TextureMapper] Move filter specific code from BitmapTextureGL to TextureMapp...
Akihiro Kiuchi
Reported
2023-09-01 00:48:00 PDT
This is a preparation refactoring for
https://bugs.webkit.org/show_bug.cgi?id=231653
. To fix the issue above, we have to change the number of passes needed to do blur filtering according to the standard deviation of the blur. Now the number of passes for each filter is specified in BitmapTextureGL.cpp but other parameters regarding filtering such as shader options are specified in TextureMapperGL.cpp, which leads to the inconsistency and low readability. My suggestion is to move the loop of passes, written in BitmapTextureGL.cpp for now, to TextureMapperGL.cpp
Attachments
Add attachment
proposed patch, testcase, etc.
Fujii Hironori
Comment 1
2023-09-01 13:53:56 PDT
PR
https://github.com/WebKit/WebKit/pull/17335
EWS
Comment 2
2023-09-03 18:35:33 PDT
Committed
267599@main
(499bdf98d4a7): <
https://commits.webkit.org/267599@main
> Reviewed commits have been landed. Closing PR #17335 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-09-03 18:36:13 PDT
<
rdar://problem/114912332
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug