RESOLVED FIXED 253563
REGRESSION(261320@main): [GLib] Clean builds fail with ENABLE_2022_GLIB_API 
https://bugs.webkit.org/show_bug.cgi?id=253563
Summary REGRESSION(261320@main): [GLib] Clean builds fail with ENABLE_2022_GLIB_API
Adrian Perez
Reported 2023-03-08 03:58:09 PST
The failure: [ 91%] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/NetworkSocketStreamMessageReceiver.cpp.o In file included from /app/webkit/WebKitBuild/Debug/wpewebkit-2.39.91/_build/DerivedSources/WebKit/wpe/webkit.h:83, from /app/webkit/WebKitBuild/Debug/wpewebkit-2.39.91/_build/DerivedSources/WebKit/wpe/WebKitEnumTypes.cpp:26: /app/webkit/WebKitBuild/Debug/wpewebkit-2.39.91/_build/DerivedSources/WebKit/wpe/WebKitWebView.h:41:10: fatal error: wpe/WebKitJavascriptResult.h: No such file or directory 41 | #include <wpe/WebKitJavascriptResult.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated.
Attachments
Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2023-03-08 04:01:49 PST
Pull request: https://github.com/WebKit/WebKit/pull/11221
EWS
Comment 2 2023-03-08 04:30:03 PST
Committed 261367@main (53a889083368): <https://commits.webkit.org/261367@main> Reviewed commits have been landed. Closing PR #11221 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-03-08 04:31:18 PST
<rdar://problem/106421089>
Adrian Perez
Comment 4 2023-03-08 04:50:39 PST
As pointed out by Carlos, we also need to remove the autocleanup for WebKitJavascriptResult 🤦️
Adrian Perez
Comment 5 2023-03-08 04:53:55 PST
Pull request: https://github.com/WebKit/WebKit/pull/11222
EWS
Comment 6 2023-03-08 05:23:30 PST
Committed 261368@main (10c9256883bf): <https://commits.webkit.org/261368@main> Reviewed commits have been landed. Closing PR #11222 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.