WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
253358
Optimize HTML parser entity names table by omitting semicolons
https://bugs.webkit.org/show_bug.cgi?id=253358
Summary
Optimize HTML parser entity names table by omitting semicolons
Ahmad Saleem
Reported
2023-03-03 16:42:44 PST
Hi Team, While merging blink commit in
bug 250640
as PR below:
https://github.com/WebKit/WebKit/pull/10888
Darin's suggested that we should look for future optimization as Blink's comment mentioned to remove 'semi-colon' storage in array: # Reuse substrings from earlier entries. This saves 1-2000 # characters, but it's O(n^2) and not very smart. The optimal # solution has to solve the "Shortest Common Superstring" problem # and that is NP-Complete or worse. # # This would be even more efficient if we didn't store the # semi-colon in the array but as a bit in the entry. __________ I am just creating this to explore it in future to fix this bug as well. If someone can guide, I am happy to look into it and if someone else can grab and do it quickly. I am happy as well. _________ Darin's comment for safe-keeping: '''This is a very good point. It would be useful to continue with this optimization and remove the semicolons from the array. I am almost certain this could be done with no performance impact.''' ___________ Just wanted to raise this bug. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-03-05 15:44:19 PST
<
rdar://problem/106264459
>
Darin Adler
Comment 2
2023-03-05 16:02:51 PST
Pull request:
https://github.com/WebKit/WebKit/pull/11089
EWS
Comment 3
2023-03-15 22:41:28 PDT
Committed
261734@main
(3483dcf98d88): <
https://commits.webkit.org/261734@main
> Reviewed commits have been landed. Closing PR #11089 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug