WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
252355
[browserperfdash-benchmark] Add optional --timestamp parameter to send the data to the server with a custom date.
https://bugs.webkit.org/show_bug.cgi?id=252355
Summary
[browserperfdash-benchmark] Add optional --timestamp parameter to send the da...
Carlos Alberto Lopez Perez
Reported
2023-02-15 15:27:57 PST
When the browserperfdash-benchmark script sends the data for a bot to a server like
https://browserperfdash.igalia.com
the data is assumed to be received now. That is fine for the general use case. But sometimes it is desirable to send data with a different date, for example for the following use cases: Use case 1) - Several boards (for example RPis) are downloading build products from the build server and doing benchmarks. It is not guaranteed that the boards end the testing in order, so it can happen that a board testing WebKit version
r12345
ends after the board testing version
r12346
. Use case 2) - Some data for older versions is missed and you want to setup a bot to test that older versions and then have the data ordered properly on the dashboard. For this use cases the runner should support a timestamp optional parameter that can be used to send the data with a specific date to the server. The server already supports this, so this bug is about implementing it on the runner.
Attachments
Add attachment
proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1
2023-02-15 15:30:54 PST
(In reply to Carlos Alberto Lopez Perez from
comment #0
) [...]
> Use case 1) > - Several boards (for example RPis) are downloading build products from the > build server and doing benchmarks. It is not guaranteed that the boards end > the > testing in order, so it can happen that a board testing WebKit version >
r12345
ends after the board testing version
r12346
. >
The idea here would be to send to the server as timestamp either the date of the build or the date of the commit that is being tested.
Carlos Alberto Lopez Perez
Comment 2
2023-02-15 16:31:23 PST
Pull request:
https://github.com/WebKit/WebKit/pull/10180
EWS
Comment 3
2023-02-15 19:21:40 PST
Committed
260345@main
(dc0001d225df): <
https://commits.webkit.org/260345@main
> Reviewed commits have been landed. Closing PR #10180 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2023-02-15 19:22:19 PST
<
rdar://problem/105528181
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug