Bug 246719 - DumpRenderTree does not seem to support PingLoad to HTTPS
Summary: DumpRenderTree does not seem to support PingLoad to HTTPS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 243428
Blocks:
  Show dependency tree / graph
 
Reported: 2022-10-18 16:02 PDT by Brent Fulgham
Modified: 2023-01-23 23:02 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2022-10-18 16:02:09 PDT 
While debugging failing Reporting API tests, I found that test cases that attempted to PingLoad to an HTTPS endpoint always fail. It seems like DRT is not properly connecting the authentication/certificate logic we use for other types of loads.

Example failure: imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.https.sub.html.

I believe this is also the cause of the failure for imported/w3c/web-platform-tests/reporting/reporting-api-honors-limits.https.sub.html.

Error: "m_localizedDescription	WTF::String	{ length = 27, contents = 'Not allowed to authenticate' }	"

It looks like this change didn't update DRT: https://github.com/WebKit/WebKit/pull/3715
Comment 1 Brent Fulgham 2022-10-24 16:44:36 PDT 
<rdar://101045517>
Comment 2 Brent Fulgham 2022-10-24 16:46:34 PDT 
This is actually:
<rdar://101040717>
Comment 3 Brent Fulgham 2022-10-26 13:57:08 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5824
Comment 4 Brent Fulgham 2022-10-28 09:32:43 PDT 
Pull request: https://github.com/Webkit/WebKit/pull/5824
Comment 5 EWS 2022-10-31 15:43:40 PDT 
Committed 256173@main (6db9bb4cc51f): <https://commits.webkit.org/256173@main>

Reviewed commits have been landed. Closing PR #5824 and removing active labels.