Bug 246573 - Fix serialization of font-stretch in font shorthand
Summary: Fix serialization of font-stretch in font shorthand
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks: 246579
  Show dependency tree / graph
 
Reported: 2022-10-15 09:14 PDT by Tim Nguyen (:ntim)
Modified: 2022-10-21 12:59 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-10-15 09:14:35 PDT 
https://wpt.fyi/results/css/css-fonts/font-shorthand-serialization-font-stretch.html?label=master&label=experimental&aligned&view=subtest

Only CSS3 keyword values for font-stretch can be serialized in the font shorthand, other values need to prevent font from serializing.
Comment 1 Darin Adler 2022-10-16 01:32:24 PDT 
The test expects peculiar behavior, where you specify a value as a percentage and it serializes as the corresponding keyword. I implemented this behavior, but I am not sure the specification actually calls for it.
Comment 2 Radar WebKit Bug Importer 2022-10-16 01:40:25 PDT 
<rdar://problem/101217780>
Comment 3 Darin Adler 2022-10-16 01:44:39 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5429
Comment 4 EWS 2022-10-17 08:14:30 PDT 
Committed 255628@main (eecfb48ef633): <https://commits.webkit.org/255628@main>

Reviewed commits have been landed. Closing PR #5429 and removing active labels.