RESOLVED FIXED 244892
[GTK4] -Wunused-function warnings from TestContextMenu.cpp 
https://bugs.webkit.org/show_bug.cgi?id=244892
Summary [GTK4] -Wunused-function warnings from TestContextMenu.cpp
Michael Catanzaro
Reported 2022-09-07 08:46:55 PDT
[434/537] Building CXX object Tools/TestWebKitAPI/glib/CMa...stContextMenu.dir/__/Tests/WebKitGtk/TestContextMenu.cpp.o /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp: In member function ‘void ContextMenuCustomTest::activateMenuItem()’: /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:617:15: warning: unused variable ‘item’ [-Wunused-variable] 617 | auto* item = getMenuItem(menu, m_itemToActivateLabel); | ^~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp: At global scope: /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:1136:13: warning: ‘void testContextMenuLiveStream(ContextMenuDefaultTest*, gconstpointer)’ defined but not used [-Wunused-function] 1136 | static void testContextMenuLiveStream(ContextMenuDefaultTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:1057:13: warning: ‘void testContextMenuWebExtensionNode(ContextMenuWebExtensionNodeTest*, gconstpointer)’ defined but not used [-Wunused-function] 1057 | static void testContextMenuWebExtensionNode(ContextMenuWebExtensionNodeTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:967:13: warning: ‘void testContextMenuWebExtensionMenu(ContextMenuWebExtensionTest*, gconstpointer)’ defined but not used [-Wunused-function] 967 | static void testContextMenuWebExtensionMenu(ContextMenuWebExtensionTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:918:13: warning: ‘void testContextMenuDismissed(ContextMenuDismissedTest*, gconstpointer)’ defined but not used [-Wunused-function] 918 | static void testContextMenuDismissed(ContextMenuDismissedTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:878:13: warning: ‘void testContextMenuSubMenu(ContextMenuSubmenuTest*, gconstpointer)’ defined but not used [-Wunused-function] 878 | static void testContextMenuSubMenu(ContextMenuSubmenuTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:830:13: warning: ‘void testContextMenuCustomMenu(ContextMenuCustomFullTest*, gconstpointer)’ defined but not used [-Wunused-function] 830 | static void testContextMenuCustomMenu(ContextMenuCustomFullTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:704:13: warning: ‘void testContextMenuPopulateMenu(ContextMenuCustomTest*, gconstpointer)’ defined but not used [-Wunused-function] 704 | static void testContextMenuPopulateMenu(ContextMenuCustomTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:565:13: warning: ‘void testContextMenuKey(ContextMenuDefaultTest*, gconstpointer)’ defined but not used [-Wunused-function] 565 | static void testContextMenuKey(ContextMenuDefaultTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:556:13: warning: ‘void testPopupEventSignal(ContextMenuDefaultTest*, gconstpointer)’ defined but not used [-Wunused-function] 556 | static void testPopupEventSignal(ContextMenuDefaultTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:509:13: warning: ‘void testContextMenuDefaultMenu(ContextMenuDefaultTest*, gconstpointer)’ defined but not used [-Wunused-function] 509 | static void testContextMenuDefaultMenu(ContextMenuDefaultTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ [457/537] Building CXX object Tools/TestWebKitAPI/glib/CMa...estOptionMenu.dir/__/Tests/WebKitGLib/TestOptionMenu.cpp.o /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp:269:13: warning: ‘void testOptionMenuSelect(OptionMenuTest*, gconstpointer)’ defined but not used [-Wunused-function] 269 | static void testOptionMenuSelect(OptionMenuTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp:239:13: warning: ‘void testOptionMenuActivate(OptionMenuTest*, gconstpointer)’ defined but not used [-Wunused-function] 239 | static void testOptionMenuActivate(OptionMenuTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp:158:13: warning: ‘void testOptionMenuGroups(OptionMenuTest*, gconstpointer)’ defined but not used [-Wunused-function] 158 | static void testOptionMenuGroups(OptionMenuTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp:116:13: warning: ‘void testOptionMenuSimple(OptionMenuTest*, gconstpointer)’ defined but not used [-Wunused-function] 116 | static void testOptionMenuSimple(OptionMenuTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~ [465/537] Building CXX object Tools/TestWebKitAPI/glib/CMa.../TestDownloads.dir/__/Tests/WebKitGLib/TestDownloads.cpp.o /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:831:13: warning: ‘void testContextMenuDownloadActions(WebViewDownloadTest*, gconstpointer)’ defined but not used [-Wunused-function] 831 | static void testContextMenuDownloadActions(WebViewDownloadTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Attachments
Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2022-09-07 08:57:41 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4100
EWS
Comment 2 2022-09-09 03:34:10 PDT
Committed 254296@main (881a95924a0b): <https://commits.webkit.org/254296@main> Reviewed commits have been landed. Closing PR #4100 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.