Bug 244283 - Re-using a bugzilla bug for a PR tried to re-use an old PR
Summary: Re-using a bugzilla bug for a PR tried to re-use an old PR
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-08-23 19:09 PDT by Simon Fraser (smfr)
Modified: 2023-01-18 11:51 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-08-23 19:09:40 PDT 
I had an existing branch for a PR for https://bugs.webkit.org/show_bug.cgi?id=244134, but had not pushed a PR yet (because of the issue in https://github.com/WebKit/WebKit/pull/3580).

When on that branch, I did `git webkit pr --no-update`, and it tried to push the PR to https://github.com/WebKit/WebKit/pull/3482. I expected it to make a new PR.
Comment 1 Simon Fraser (smfr) 2022-08-23 19:22:53 PDT 
Then I got stuck on my local PR branch, unable to specify a new bug to push to. I then deleted this branch with `git branch -D` but I still get:

OpenSource % git webkit pr --issue 244285
'eng/REGRESSION253549main--iOS--2X-animationsLayout-tests-are-constant-failures' already exists
Abandoning pushing pull-request because 'eng/REGRESSION253549main--iOS--2X-animationsLayout-tests-are-constant-failures' could not be created
Comment 2 Radar WebKit Bug Importer 2022-08-23 20:36:27 PDT 
<rdar://problem/99065079>
Comment 3 Jonathan Bedard 2023-01-18 11:51:35 PST 
This is either fixed by https://bugs.webkit.org/show_bug.cgi?id=244660 or not-to-be-fixed.

Ultimately, GitHub uses branch names as the primary identifier for PRs. We can use state and author to further differentiate, but beyond that, branch names are the primary PR identifier.