Bug 243621 - [Painting] Do not call textRunOffsetFromBottomMost() unless the resolved underline position value is TextUnderlinePosition::Under
Summary: [Painting] Do not call textRunOffsetFromBottomMost() unless the resolved unde...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 243766
  Show dependency tree / graph
 
Reported: 2022-08-05 22:45 PDT by zalan
Modified: 2022-08-14 14:06 PDT (History)
7 users (show)

See Also:

Attachments
Patch (13.21 KB, patch)
2022-08-05 22:57 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.75 KB, patch)
2022-08-06 14:12 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-08-05 22:45:44 PDT 
textRunOffsetFromBottomMost() is expensive
Comment 1 zalan 2022-08-05 22:57:30 PDT 
Created attachment 461436 [details]
Patch
Comment 2 zalan 2022-08-06 14:12:28 PDT 
Created attachment 461445 [details]
Patch
Comment 3 EWS 2022-08-06 16:31:32 PDT 
Committed 253186@main (3f94a77b8952): <https://commits.webkit.org/253186@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461445 [details].
Comment 4 Radar WebKit Bug Importer 2022-08-06 16:32:16 PDT 
<rdar://problem/98254665>