RESOLVED FIXED 24340
Expose allowUniversalAccessFromFileUrls to Qt 
https://bugs.webkit.org/show_bug.cgi?id=24340
Summary Expose allowUniversalAccessFromFileUrls to Qt
Adam Barth
Reported 2009-03-03 17:46:38 PST
Clients of the QT port might want to set allowUniversalAccessFromFileUrls. We should expose it in http://trac.webkit.org/browser/trunk/WebKit/qt/Api/qwebsettings.h
Attachments
patch (2.80 KB, patch)
2009-03-03 18:02 PST, Adam Barth 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-03-03 18:02:31 PST
Created attachment 28252 [details] patch I can't build QT, but this patch is trivially simple (meaning it will probably only break the build in two ways).
Alexey Proskuryakov
Comment 2 2009-03-04 00:20:37 PST
QT is QuickTime, re-titling.
Alexey Proskuryakov
Comment 3 2009-03-04 00:29:38 PST
Comment on attachment 28252 [details] patch + Reviewed by NOBODY (OOPS!). + + Expose AllowUniversalAccessFromFileUrls to QT clients. Please add a bug URL. r=me, but AllowUniversalAccessFromFileUrls should really be AllowUniversalAccessFromFileURLs - not just in Qt, but everywhere. It's particularly unfortunate to have this exposed as a (private) preference, could you please rename all instances? A separate patch would probably be more appropriate.
Brian Ellis
Comment 4 2009-03-04 00:40:54 PST
(In reply to comment #3) > r=me, but AllowUniversalAccessFromFileUrls should really be > AllowUniversalAccessFromFileURLs - not just in Qt, but everywhere. It's > particularly unfortunate to have this exposed as a (private) preference, could > you please rename all instances? A separate patch would probably be more > appropriate. "URL" is consistent with the naming of preferences in WebCore, but Qt uses "Url" instead of "URL" pretty universally -- see e.g. the QUrl class and the QWebPage method "userAgentForUrl". Perhaps it should be left alone in QtWebKit and changed elsewhere?
Adam Barth
Comment 5 2009-03-04 09:34:00 PST
> could you please rename all instances? A separate patch would probably be more > appropriate. Filed as: https://bugs.webkit.org/show_bug.cgi?id=24356
Adam Barth
Comment 6 2009-03-04 09:39:59 PST
Sending WebKit/qt/Api/qwebsettings.cpp Sending WebKit/qt/Api/qwebsettings.h Sending WebKit/qt/ChangeLog Transmitting file data ... Committed revision 41421.
Note You need to log in before you can comment on or make changes to this bug.