Bug 242359 - [Filters] Implement no-op filters
Summary: [Filters] Implement no-op filters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
: 114032 165110 (view as bug list)
Depends on:
Blocks: 231253
  Show dependency tree / graph
 
Reported: 2022-07-05 13:35 PDT by Said Abou-Hallawa
Modified: 2023-06-06 13:44 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2022-07-05 13:35:16 PDT 
We should only draw the sourceImage is the whole filter chain is Noop (no-operation). At least This will save us from duplicating the sourceImage for SourceGraphic.

Are Noop filters common? Yes some pages may initially display their images blurred then decrease the blur radius to zero through animation. So every time these images are displayed after that will be displayed as filtered images even the applied filter has no effect.
Comment 1 Said Abou-Hallawa 2022-07-05 13:47:50 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2092
Comment 2 Radar WebKit Bug Importer 2022-07-12 13:36:20 PDT 
<rdar://problem/96907495>
Comment 3 EWS 2022-08-03 20:07:13 PDT 
Committed 253098@main (4ac8e180ed02): <https://commits.webkit.org/253098@main>

Reviewed commits have been landed. Closing PR #2092 and removing active labels.
Comment 4 Said Abou-Hallawa 2023-06-06 13:44:14 PDT 
*** Bug 114032 has been marked as a duplicate of this bug. ***
Comment 5 Said Abou-Hallawa 2023-06-06 13:44:36 PDT 
*** Bug 165110 has been marked as a duplicate of this bug. ***