Bug 240900 - Consider not generating a full commit message on each commit before squashing
Summary: Consider not generating a full commit message on each commit before squashing
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-05-24 22:33 PDT by Manuel Rego Casasnovas
Modified: 2022-05-31 22:34 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2022-05-24 22:33:16 PDT 
Maybe this is just me, but when I work on a patch, I usually have a local branch where I do a lot of small commits.

For these commits I use simple "one liner" commit messages.

Once I have something useful for sending to review, then I squash these commits together, and write a proper commit message and the like.

The problem I see with the new GitHub workflow, is that every local commit, is running the pre-commit hook, and generating a very big commit messsage. I found a way to skip that with "git commit -m" but I wonder if this is the right default or not.

When I'm running "git-webkit upload" then I'd be happy to be asked to provide a good commit message and all that, but before that it seems like noise to my way of working.

WDYT?
Comment 1 Radar WebKit Bug Importer 2022-05-31 22:34:13 PDT 
<rdar://problem/94200445>