RESOLVED FIXED 239132
[GTK] Remove WebKitInstallMissingMediaPluginsPermissionRequest 
https://bugs.webkit.org/show_bug.cgi?id=239132
Summary [GTK] Remove WebKitInstallMissingMediaPluginsPermissionRequest
Michael Catanzaro
Reported 2022-04-12 10:40:32 PDT
The WebKitInstallMissingMediaPluginsPermissionRequest API has been broken for six years, ever since we fixed bug #135972. Let's remove this from our GTK 4 API. We might eventually create a new API to handle codec installation, see bug #147822, but I don't think it's terribly urgent or important. Normally you can either offer codecs and install them by default (e.g. Debian), or you can't offer them at all (e.g. Fedora). Having a codec installer that's either not needed or cannot work is not super useful either way.
Attachments
Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2022-09-08 07:57:57 PDT
Note there are D-Bus permissions for this in XDGDBusProxy.cpp that should be removed. Also we should deprecate the APIs in the old API version, as they haven't been deprecated yet.
Michael Catanzaro
Comment 2 2022-09-08 07:58:28 PDT
Also should remove /webkit2/WebKitWebView/install-missing-plugins-permission-request and any failure expectations.
Philippe Normand
Comment 3 2023-01-05 01:18:01 PST
I agree, I'll prepare a patch for this.
Philippe Normand
Comment 4 2023-01-05 03:01:03 PST
Pull request: https://github.com/WebKit/WebKit/pull/8232
EWS
Comment 5 2023-01-09 01:53:57 PST
Committed 258653@main (209971efaec5): <https://commits.webkit.org/258653@main> Reviewed commits have been landed. Closing PR #8232 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.