RESOLVED FIXED 238200
Move TextureMapper member variables, types and code out of GraphicsContextGLANGLE 
https://bugs.webkit.org/show_bug.cgi?id=238200
Summary Move TextureMapper member variables, types and code out of GraphicsContextGLA...
Zan Dobersek
Reported 2022-03-22 05:55:24 PDT
Move TextureMapper member variables, types and code out of GraphicsContextGLANGLE
Attachments
Patch (15.48 KB, patch)
2022-03-22 05:55 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2022-03-22 05:55:53 PDT
Created attachment 455364 [details] Patch
Alejandro G. Castro
Comment 2 2022-03-22 06:17:00 PDT
Comment on attachment 455364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455364&action=review LGTM! Great refactor, just added a small comment. > Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:82 > +#if USE(COORDINATED_GRAPHICS) > + GCGLuint m_intermediateTexture { 0 }; > +#endif > + > +#if USE(NICOSIA) > + std::unique_ptr<Nicosia::GCGLANGLELayer> m_nicosiaLayer; Could we use remove of of the #ifs here and joing the two code sections?
Zan Dobersek
Comment 3 2022-03-22 06:24:23 PDT
Comment on attachment 455364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455364&action=review >> Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:82 >> + std::unique_ptr<Nicosia::GCGLANGLELayer> m_nicosiaLayer; > > Could we use remove of of the #ifs here and joing the two code sections? I'm just moving code around, I'm not making these decisions ATM.
EWS
Comment 4 2022-03-22 07:49:19 PDT
Committed r291616 (248709@main): <https://commits.webkit.org/248709@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455364 [details].
Radar WebKit Bug Importer
Comment 5 2022-03-22 07:50:18 PDT
<rdar://problem/90635015>
Fujii Hironori
Comment 6 2022-03-22 14:17:45 PDT
Does this change match Kimmo's plan (bug#236769 comment#0)?
Zan Dobersek
Comment 7 2022-03-23 02:05:36 PDT
This one: > The long-term plan would be to minimise the ifdefs in GraphicsContextGLANGLE. It doesn't affect others.
Note You need to log in before you can comment on or make changes to this bug.