RESOLVED FIXED 230244
Implement text-decoration-skip-ink 
https://bugs.webkit.org/show_bug.cgi?id=230244
Summary Implement text-decoration-skip-ink
Myles C. Maxfield
Reported 2021-09-13 21:33:35 PDT
Implement text-decoration-skip-ink
Attachments
WIP (28.47 KB, patch)
2021-09-13 21:35 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (88.44 KB, patch)
2021-09-14 00:41 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (88.79 KB, patch)
2021-09-14 00:52 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (89.57 KB, patch)
2021-09-14 02:30 PDT, Myles C. Maxfield 		koivisto: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-09-13 21:35:37 PDT
Created attachment 438100 [details] WIP
Myles C. Maxfield
Comment 2 2021-09-13 23:28:35 PDT
Failing tests: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation.html imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties.html imported/w3c/web-platform-tests/css/css-text-decor/inheritance.html imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-decoration-skip-ink-computed.html imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-decoration-skip-ink-valid.html imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-skip-ink.html imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext.html imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
Myles C. Maxfield
Comment 3 2021-09-14 00:41:04 PDT
Created attachment 438109 [details] Patch
Myles C. Maxfield
Comment 4 2021-09-14 00:52:29 PDT
Created attachment 438110 [details] Patch
Myles C. Maxfield
Comment 5 2021-09-14 02:30:04 PDT
Created attachment 438116 [details] Patch
Antti Koivisto
Comment 6 2021-09-14 06:27:34 PDT
Comment on attachment 438116 [details] Patch Seems reasonable, r=me
Myles C. Maxfield
Comment 7 2021-09-14 11:39:11 PDT
Committed r282397 (241658@main): <https://commits.webkit.org/241658@main>
Radar WebKit Bug Importer
Comment 8 2021-09-14 11:40:38 PDT
<rdar://problem/83109958>
Darin Adler
Comment 9 2021-09-14 16:42:58 PDT
Comment on attachment 438116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438116&action=review > Source/WebCore/css/parser/CSSPropertyParser.cpp:1681 > + if (RefPtr<CSSPrimitiveValue> skip = consumeIdent<CSSValueNone, CSSValueAuto, CSSValueInk>(m_range)) { auto
Tim Nguyen (:ntim)
Comment 10 2022-05-19 07:09:17 PDT
*** Bug 95848 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.