RESOLVED FIXED 223673
[Catalina WK2] 5 media/modern-media-controls/tracks-support tests consistently timing out 
https://bugs.webkit.org/show_bug.cgi?id=223673
Summary [Catalina WK2] 5 media/modern-media-controls/tracks-support tests consistentl...
Ryan Haddad
Reported 2021-03-23 21:26:29 PDT
The following tests have been consistently timing out on Catalina WK2 bots since they were added/enabled with https://trac.webkit.org/changeset/274521/webkit media/modern-media-controls/tracks-support/auto-text-track.html media/modern-media-controls/tracks-support/click-track-in-contextmenu.html media/modern-media-controls/tracks-support/hidden-tracks.html media/modern-media-controls/tracks-support/off-text-track.html media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=media%2Fmodern-media-controls%2Ftracks-support%2Fauto-text-track.html&test=media%2Fmodern-media-controls%2Ftracks-support%2Fclick-track-in-contextmenu.html&test=media%2Fmodern-media-controls%2Ftracks-support%2Fhidden-tracks.html&test=media%2Fmodern-media-controls%2Ftracks-support%2Foff-text-track.html&test=media%2Fmodern-media-controls%2Ftracks-support%2Ftext-track-selected-via-media-api.html
Attachments
[Patch] test for EWS to tell me what `contextmenu` is (5.04 KB, patch)
2021-03-24 15:56 PDT, Devin Rousso 		hi: review-
hi: commit-queue-
DetailsFormatted DiffDiff
[Patch] test for EWS to tell me what `contextmenu` is (after removing test expectations) (6.03 KB, patch)
2021-03-24 15:57 PDT, Devin Rousso 		hi: commit-queue-
DetailsFormatted DiffDiff
[Patch] test for EWS to tell me what `contextmenu` is (after removing test expectations) (6.03 KB, patch)
2021-03-24 16:08 PDT, Devin Rousso 		hi: commit-queue-
DetailsFormatted DiffDiff
Patch (6.72 KB, patch)
2021-03-30 16:44 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-23 21:26:37 PDT
<rdar://problem/75769577>
Ryan Haddad
Comment 2 2021-03-23 21:28:03 PDT
Devin, are these tests supposed to work on Catalina or should they be skipped?
Devin Rousso
Comment 3 2021-03-24 15:10:38 PDT
Yeah I think these should work in Catalina. I wonder why they're working in Big Sur and not Catalina 🤔 I do see ``` CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'subtitlesMenu.children') ``` in the output, so perhaps adding a ``` -if (subtitlesMenu.children?.length) { +if (subtitlesMenu?.children?.length) { ``` would fix this?
Devin Rousso
Comment 4 2021-03-24 15:56:13 PDT
Created attachment 424194 [details] [Patch] test for EWS to tell me what `contextmenu` is
Devin Rousso
Comment 5 2021-03-24 15:57:54 PDT
Created attachment 424195 [details] [Patch] test for EWS to tell me what `contextmenu` is (after removing test expectations)
Devin Rousso
Comment 6 2021-03-24 16:08:10 PDT
Created attachment 424197 [details] [Patch] test for EWS to tell me what `contextmenu` is (after removing test expectations)
Devin Rousso
Comment 7 2021-03-24 21:22:09 PDT
This testing patch that I've uploaded suggests that these tests are passing on mac-wk2 (which I believe is Catalina), so I'm not really sure what to do here :/
Truitt Savell
Comment 8 2021-03-25 16:00:46 PDT
From looking around this issue seems to only reproduce on the Macmini8,1s on Catalina. locally I can only get a timeout running in wk1 which these tests are not ran on in production.
Devin Rousso
Comment 9 2021-03-30 16:44:13 PDT
Created attachment 424715 [details] Patch
EWS
Comment 10 2021-03-30 21:20:12 PDT
Committed r275265: <https://commits.webkit.org/r275265> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424715 [details].
Note You need to log in before you can comment on or make changes to this bug.