RESOLVED FIXED 223627
ANGLE Metal fixes for program generation bugs 
https://bugs.webkit.org/show_bug.cgi?id=223627
Summary ANGLE Metal fixes for program generation bugs
Kyle Piddington
Reported 2021-03-23 00:31:09 PDT
The following three tests hit debug assertions when generating programs, and produce invalid programs on release. webgl/2.0.0/conformance2/glsl3/texture-offset-uniform-texture-coordinate.html webgl/2.0.0/conformance/glsl/bugs/compound-assignment-type-combination.html webgl/2.0.0/conformance/glsl/bugs/complex-glsl-does-not-crash.html
Attachments
Patch (44.51 KB, patch)
2021-03-23 00:33 PDT, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (44.49 KB, patch)
2021-03-23 08:49 PDT, Kyle Piddington 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kyle Piddington
Comment 1 2021-03-23 00:33:22 PDT
Created attachment 423993 [details] Patch
EWS Watchlist
Comment 2 2021-03-23 00:34:22 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Jon Lee
Comment 3 2021-03-23 00:48:31 PDT
Comment on attachment 423993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423993&action=review > Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/ProgramPrelude.cpp:3562 > + } missing break?
Kyle Piddington
Comment 4 2021-03-23 08:49:32 PDT
Created attachment 424021 [details] Patch
EWS
Comment 5 2021-03-23 11:23:06 PDT
Committed r274884: <https://commits.webkit.org/r274884> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424021 [details].
Radar WebKit Bug Importer
Comment 6 2021-03-23 11:24:13 PDT
<rdar://problem/75746599>
Note You need to log in before you can comment on or make changes to this bug.