RESOLVED FIXED 217342
[GPU Process] Implement GPU rendering resource cache 
https://bugs.webkit.org/show_bug.cgi?id=217342
Summary [GPU Process] Implement GPU rendering resource cache
Said Abou-Hallawa
Reported 2020-10-05 15:13:29 PDT
All the rendering resources, such as ImageFrames, Fonts and ImageBuffers will be cached in the GPU side. Managing this cache will be done by RemoteRenderingBackend and RemoteRenderingBackendProxy. Both of these objects will have a separate objects for maintaining the cached objects. The goal is to have these objects cached once and referenced by their ids multiple times.
Attachments
Patch (166.36 KB, patch)
2020-10-05 15:33 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (174.74 KB, patch)
2020-10-05 18:09 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (178.05 KB, patch)
2020-10-05 22:25 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (178.39 KB, patch)
2020-10-05 23:40 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (185.69 KB, patch)
2020-10-07 02:00 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (182.46 KB, patch)
2020-10-07 02:17 PDT, Said Abou-Hallawa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (183.13 KB, patch)
2020-10-07 02:25 PDT, Said Abou-Hallawa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2020-10-05 15:33:06 PDT
Created attachment 410571 [details] Patch
Said Abou-Hallawa
Comment 2 2020-10-05 18:09:14 PDT
Created attachment 410597 [details] Patch
Said Abou-Hallawa
Comment 3 2020-10-05 22:25:23 PDT
Created attachment 410613 [details] Patch
Said Abou-Hallawa
Comment 4 2020-10-05 23:40:34 PDT
Created attachment 410617 [details] Patch
Myles C. Maxfield
Comment 5 2020-10-06 22:27:19 PDT
Comment on attachment 410617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410617&action=review It seems like there will be 3 or 4 patches in here once this is broken up. I'll review those in more detail (just because this one is pretty big). > Source/WebCore/platform/graphics/GraphicsContext.cpp:795 > + if (m_impl && image.isPDFDocumentImage()) Why is this relevant? > Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:-292 > - if (m_impl) { > - m_impl->drawNativeImage(image, imageSize, destRect, srcRect, options); > - return; > - } > - This is surprising.
Said Abou-Hallawa
Comment 6 2020-10-07 02:00:19 PDT
Created attachment 410738 [details] Patch
Said Abou-Hallawa
Comment 7 2020-10-07 02:17:19 PDT
Created attachment 410739 [details] Patch
Said Abou-Hallawa
Comment 8 2020-10-07 02:25:44 PDT
Created attachment 410740 [details] Patch
Radar WebKit Bug Importer
Comment 9 2020-10-08 19:46:24 PDT
<rdar://problem/70122760>
Simon Fraser (smfr)
Comment 10 2021-01-06 09:16:21 PST
Is this patch still useful?
Said Abou-Hallawa
Comment 11 2021-03-05 10:50:02 PST
The attached patch was split and landed separately in the blocking bugs.
Note You need to log in before you can comment on or make changes to this bug.