217216 – Implement RemoteGraphicsContextGL

RESOLVED FIXED 217216

Implement RemoteGraphicsContextGL

https://bugs.webkit.org/show_bug.cgi?id=217216

Summary Implement RemoteGraphicsContextGL

Kimmo Kinnunen

Reported 2020-10-02 04:30:36 PDT

Implement RemoteWebGLBackend that creates RemoteGraphicsContextsGL instances

Attachments
Patch (315.83 KB, patch) 2020-11-03 05:26 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (353.51 KB, patch) 2020-11-22 05:10 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (374.34 KB, patch) 2020-11-23 02:23 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (510.23 KB, patch) 2020-11-30 08:06 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (549.54 KB, patch) 2020-12-01 02:25 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (547.54 KB, patch) 2020-12-01 03:20 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (551.13 KB, patch) 2020-12-01 03:33 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (551.12 KB, patch) 2020-12-01 03:48 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (551.12 KB, patch) 2020-12-01 03:52 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (551.48 KB, patch) 2020-12-01 04:05 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (554.69 KB, patch) 2020-12-01 04:20 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (554.89 KB, patch) 2020-12-01 04:22 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (554.76 KB, patch) 2020-12-01 04:33 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (555.36 KB, patch) 2020-12-01 04:44 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (568.52 KB, patch) 2020-12-01 05:57 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (568.66 KB, patch) 2020-12-01 08:17 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (551.98 KB, patch) 2020-12-02 03:10 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (555.53 KB, patch) 2020-12-02 06:06 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (556.13 KB, patch) 2020-12-02 06:11 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (556.37 KB, patch) 2020-12-02 06:46 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (567.83 KB, patch) 2020-12-02 07:03 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (567.88 KB, patch) 2020-12-02 07:13 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (567.90 KB, patch) 2020-12-02 07:20 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (571.17 KB, patch) 2020-12-03 01:44 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (402.85 KB, patch) 2020-12-03 05:44 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (403.75 KB, patch) 2020-12-04 01:42 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (403.41 KB, patch) 2020-12-09 00:05 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (404.37 KB, patch) 2020-12-09 00:34 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (405.19 KB, patch) 2020-12-09 01:30 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (406.15 KB, patch) 2020-12-09 04:07 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Show Obsolete (29) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-10-02 04:30:50 PDT

<rdar://problem/69876258>

Kimmo Kinnunen

Comment 2 2020-11-03 05:26:38 PST

Created attachment 413049 [details] Patch

Kimmo Kinnunen

Comment 3 2020-11-22 05:10:26 PST

Created attachment 414787 [details] Patch

Kimmo Kinnunen

Comment 4 2020-11-23 02:23:31 PST

Created attachment 414797 [details] Patch

Dean Jackson

Comment 5 2020-11-25 01:24:56 PST

Comment on attachment 414797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414797&action=review This looks great to me! > Source/WebCore/platform/graphics/GraphicsContextGL.h:675 > + REQUESTABLE_EXTENSIONS_ANGLE = 0x93A8, // NOLINT What does the NOLINT mean? > Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.h:30 > + void activeTexture(GCGLenum texture) final People might complain about the indentation here. > Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.h:147 > + sendSync(Messages::RemoteGraphicsContextGL::CreateFramebuffer(), Messages::RemoteGraphicsContextGL::CreateFramebuffer::Reply(returnValue), m_graphicsContextGLIdentifier, 1_s); I wonder if we should have a local sendSync form that calls sendSync adding the m_graphicsContextGLIdentifier and timeout?

Kimmo Kinnunen

Comment 6 2020-11-30 08:06:23 PST

Created attachment 415024 [details] Patch

Kimmo Kinnunen

Comment 7 2020-12-01 02:25:11 PST

Created attachment 415117 [details] Patch

Kimmo Kinnunen

Comment 8 2020-12-01 03:20:23 PST

Created attachment 415121 [details] Patch

Kimmo Kinnunen

Comment 9 2020-12-01 03:33:51 PST

Created attachment 415122 [details] Patch

Kimmo Kinnunen

Comment 10 2020-12-01 03:48:10 PST

Created attachment 415123 [details] Patch

Kimmo Kinnunen

Comment 11 2020-12-01 03:52:59 PST

Created attachment 415124 [details] Patch

Kimmo Kinnunen

Comment 12 2020-12-01 04:05:15 PST

Created attachment 415125 [details] Patch

Kimmo Kinnunen

Comment 13 2020-12-01 04:20:09 PST

Created attachment 415126 [details] Patch

Kimmo Kinnunen

Comment 14 2020-12-01 04:22:17 PST

Created attachment 415127 [details] Patch

Kimmo Kinnunen

Comment 15 2020-12-01 04:33:16 PST

Created attachment 415128 [details] Patch

Kimmo Kinnunen

Comment 16 2020-12-01 04:44:26 PST

Created attachment 415129 [details] Patch

Kimmo Kinnunen

Comment 17 2020-12-01 05:57:04 PST

Created attachment 415131 [details] Patch

Kimmo Kinnunen

Comment 18 2020-12-01 08:17:46 PST

Created attachment 415135 [details] Patch

Kimmo Kinnunen

Comment 19 2020-12-02 03:10:52 PST

Created attachment 415202 [details] Patch

Kimmo Kinnunen

Comment 20 2020-12-02 06:06:26 PST

Created attachment 415216 [details] Patch

Kimmo Kinnunen

Comment 21 2020-12-02 06:11:35 PST

Created attachment 415218 [details] Patch

Kimmo Kinnunen

Comment 22 2020-12-02 06:46:43 PST

Created attachment 415219 [details] Patch

Kimmo Kinnunen

Comment 23 2020-12-02 07:03:28 PST

Created attachment 415220 [details] Patch

Kimmo Kinnunen

Comment 24 2020-12-02 07:13:39 PST

Created attachment 415221 [details] Patch

Kimmo Kinnunen

Comment 25 2020-12-02 07:20:38 PST

Created attachment 415223 [details] Patch

Kimmo Kinnunen

Comment 26 2020-12-03 01:44:08 PST

Created attachment 415285 [details] Patch

Kimmo Kinnunen

Comment 27 2020-12-03 05:44:45 PST

Created attachment 415297 [details] Patch

Kimmo Kinnunen

Comment 28 2020-12-04 01:42:04 PST

Created attachment 415394 [details] Patch

Simon Fraser (smfr)

Comment 29 2020-12-08 14:22:02 PST

Comment on attachment 415394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415394&action=review > Source/WebCore/page/Chrome.cpp:553 > + // TODO: GPU process. Change to GCGLManager, make it work, return null for others. Maybe file a bug and reference it here to track the work. > Source/WebCore/platform/graphics/RemoteGraphicsContextGLProxyBase.cpp:48 > +void RemoteGraphicsContextGLProxyBase::setContextVisibility(bool) > +{ > +} Should these implementations ASSERT_NOT_REACHED? > Source/WebCore/platform/graphics/cocoa/GraphicsContextGLIOSurfaceSwapChain.h:49 > + void* handle { nullptr }; // Producer specific metadata handle (such as EGLSurface). It's unclear what the ownership model is for this handle. > Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:379 > + GraphicsContextGLIdentifier m_graphicsContextGLIdentifier { GraphicsContextGLIdentifier::generate() }; This object identifier does not guarantee uniqueness between WebContent processes, but it must.

Kimmo Kinnunen

Comment 30 2020-12-09 00:05:07 PST

Created attachment 415724 [details] Patch

Kimmo Kinnunen

Comment 31 2020-12-09 00:34:04 PST

Created attachment 415727 [details] Patch

Kimmo Kinnunen

Comment 32 2020-12-09 01:30:45 PST

Created attachment 415729 [details] Patch

Kimmo Kinnunen

Comment 33 2020-12-09 04:07:02 PST

Created attachment 415739 [details] Patch

EWS

Comment 34 2020-12-09 10:32:57 PST

Committed r270587: <https://trac.webkit.org/changeset/270587> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415739 [details].

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P1

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Mac

OS Unspecified

Product WebKit

Component WebGL

Assignee

Kimmo Kinnunen

Reported

2020-10-02 04:30 PDT

Modified

2020-12-09 10:32 PST History

CC List

23 users Show

URL

Keywords InRadar

Depends on

217213 219431 219486 219487

Blocks

webglgpup

Dependencies

tree graph

annulen
cdumez
changseok
cmarcelo
dino
eric.carlson
esprehn+autocc
ews-watchlist
glenn
graouts
gyuyoung.kim
hi
jer.noble
jiewen_tan
joepeck
kondapallykalyan
luiz
mkwst
philipj
ryuan.choi
sergio
simon.fraser
webkit-bug-importer